Report profiler version #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to accomplish the same results with dynamic data bindings instead of just rendering a static template.
wolfs
requested changes
Sep 11, 2020
build.gradle.kts
Outdated
| manifest { | ||
| attributes( | ||
| "Implementation-Title" to "Gradle Profiler", | ||
| "Implementation-Version" to archiveVersion |
There was a problem hiding this comment.
I think it would be better to use project.version here, since we may remove the version from the archive name.
| "definition": { | ||
| stringWriter.toString() ==~ /\{ | ||
| "environment": \{ | ||
| "profilerVersion": ".*" |
There was a problem hiding this comment.
The version should be available here, so you could assert the actual version string, right?
There was a problem hiding this comment.
It is UNKNOWN if you try to run the test from classes. But... yeah, we could do it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the profiler version in the HTML report and on the command-line.
Fixes #171