Support passing toolHome to Maven/Buck/Bazel invoker #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindpirate
force-pushed
the
blindpirate/tool-home
branch
2 times, most recently
from
ade0fdc
to
dee7b20
Compare
wolfs
requested changes
Sep 14, 2020
There was a problem hiding this comment.
I think we should add a separate base class for the (Maven|Bazel)ScenarioDefinition and the (Maven|Bazel)ScenarioInvoker. Then we can move the shared code from ScenarioInvoker there, instead of leaving the code in ScenarioInvoker and not using it in GradleScenarioInvoker.
|
@blindpirate There are quite some changes regarding the invokers going on in #253, I think we should hold off with this PR until #253 has been merged. |
wolfs
changed the title
|
@blindpirate #253 has been merged, so we can go forward with this change. |
So that they can be invoked programmatically more easily.
blindpirate
force-pushed
the
blindpirate/tool-home
branch
from
dee7b20
to
33df461
Compare
wolfs
reviewed
Sep 18, 2020
src/main/java/org/gradle/profiler/BuildToolCommandLineScenarioDefinition.java
Show resolved
Hide resolved
blindpirate
force-pushed
the
blindpirate/tool-home
branch
from
8fdcaa2
to
3a388c3
Compare
wolfs
approved these changes
Sep 18, 2020
|
Thanks @wolfs ! sure I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that they can be invoked programmatically more easily.
Fixes #245