Add more details to HTML report #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
force-pushed
the
lptr/add-details-to-html-report
branch
3 times, most recently
from
eec05b4
to
957ad7f
Compare
lptr
commented
Sep 15, 2020
| @@ -65,7 +65,7 @@ public static String safeFileName(String name) { | |||
|
|
|||
| @Override | |||
| public String getBuildToolDisplayName() { | |||
| return buildConfiguration.getGradleVersion().getVersion(); | |||
| return buildConfiguration.getGradleVersion().toString(); | |||
There was a problem hiding this comment.
So the build tool for Gradle scenarios gets displayed as Gradle 6.7, not 6.7.
lptr
force-pushed
the
lptr/add-details-to-html-report
branch
from
1142b34
to
3ba8a23
Compare
lptr
force-pushed
the
lptr/add-details-to-html-report
branch
from
3ba8a23
to
d944a01
Compare
wolfs
requested changes
Sep 16, 2020
| json.addProperty("name", scenario.getName()); | ||
| json.addProperty("title", scenario.getTitle()); | ||
| json.addProperty("displayName", scenario.getDisplayName()); | ||
| json.addProperty("buildTool", scenario.getBuildToolDisplayName()); |
There was a problem hiding this comment.
Maybe the build tool should only be Gradle and not include the version number given that we have the version number in a separate property?
There was a problem hiding this comment.
I agree, but let's do it in a separate PR.
|
We are now showing the build tool in parenthesis after the scenario title if and only if there are different build tools invoked during the benchmark:
If all scenarios are executed with the same build tool (in the case of Gradle it means the same version), then the build tool version is only shown in the details view after pressing +.
|
wolfs
requested changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some extra information like the system properties and Java home.
Improves #161.
Reports:
test-html-report.zip