-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for profiling and benchmarking Android Studio sync #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a quick first pass at the changes. I can confirm it fails gracefully on Linux. Will give it a try on a mac later Today.
src/main/java/org/gradle/profiler/studio/LauncherConfigurationParser.java
Outdated
Show resolved
Hide resolved
Tried on a mac against Studio 4.2 Canary 11 installed via the JetBrains Toolbox and I got:
Here's the |
Exact same problem with 4.1 RC3 or 4.0. |
Also extract a couple of convention plugins into `buildSrc`.
…it for the agent to connect back. Add `--studio-install-dir` command-line option, which is required when measuring an Android Studio sync.
…ific client implementation.
… Studio. These are used during sync.
…e by Android Studio during sync.
… sync in Android Studio.
5269ef3
to
87ad096
Compare
I've switched to using the dd-plist library. Can you try this again? |
I've addressed the review comments. I'm going to merge this, and we can do any fixes in a follow up PR. |
@adammurdoch with the changes in #268 I was able to make it work |
Replaces the previous "sync mock" with a real sync triggered from Android Studio.
Introduces a new "Gradle client" implementation that runs Studio with an agent that intercepts calls to the tooling API in order to inject the correct settings and collect duration information.
This initial implementation has a few limitations:
These are things that could be improved in the future.