Release automatically to SDKMAN #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we only announce and set the default version for a final release.
lptr
requested changes
Oct 2, 2020
|
|
||
| tasks.register("releaseToSdkMan") { | ||
| val versionString = project.version.toString() | ||
| val isFinalRelease = Regex("""[0-9\.]*""").matchEntire(versionString) != null |
There was a problem hiding this comment.
This could use a bit of commenting. And it would be great to mention the release logic and the fact that we are publishing to SDKMAN in the RELEASING.md. That file is in dire need of updating anyway.
There was a problem hiding this comment.
I added a comment and updated the release instructions.
There was a problem hiding this comment.
Thanks. I think the way the version number format controls the SDKMAN publishing behavior should also be mentioned in RELEASING.md.
There was a problem hiding this comment.
I added it the releasing instructions as well.
|
@lptr PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishes releases automatically to SDKMAN.