Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure garbage collection time #277

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Measure garbage collection time #277

merged 3 commits into from
Oct 2, 2020

Conversation

lptr
Copy link
Member

@lptr lptr commented Oct 2, 2020

What it says on the tin. Enable with --measure-gc.

image

@lptr lptr added this to the 0.15.0 milestone Oct 2, 2020
@lptr lptr requested a review from wolfs October 2, 2020 14:46
@lptr lptr self-assigned this Oct 2, 2020
@lptr
Actually measure the GC time since the last time we measured it
fe6c1ac 
This way we don't ignore GC time that happens before the init script is executed, or between builds.
@lptr
Copy link
Member Author

lptr commented Oct 2, 2020

I've tried two approaches to capturing the time, see the two commits.

wolfs
wolfs reviewed Oct 2, 2020
View reviewed changes
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add the new flag to the README as well?

@lptr lptr merged commit 38865a1 into master Oct 2, 2020
@lptr lptr deleted the lptr/measure-gc branch October 2, 2020 19:53
@lptr lptr mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfs wolfs wolfs left review comments

Assignees

@lptr lptr

Labels
enhancement
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lptr @wolfs