Fix pid instrumentation on Eclipse J9 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfs
force-pushed
the
wolfs/support-j9
branch
from
37d7258
to
0cbba07
Compare
wolfs
force-pushed
the
wolfs/support-j9
branch
from
0cbba07
to
3f97778
Compare
wolfs
force-pushed
the
wolfs/support-j9
branch
from
3f97778
to
c390a9c
Compare
lptr
approved these changes
Dec 18, 2020
| protected Long getPid() { | ||
| try { | ||
| // With Gradle 6.6 we can't inject `ProcessEnvironment`, so that is why we access the runtime MXBean here. | ||
| // On Java 9 we could use the nicer ProcessHandle. |
There was a problem hiding this comment.
It's not "could" anymore. Maybe also point to PidCollectorBuildService from here?
There was a problem hiding this comment.
Good catch! I adjusted the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
ProcessHandleAPI when available instead of using the proprietaryMXBean. This should fix the PID instrumentation when using Eclipse J9 JVM.Fixes #294