Run some tests on Java 11 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still don't understand why we had 5 entries in the cache.
lptr
reviewed
Dec 16, 2020
.teamcity/settings/extensions.kt
Outdated
| @@ -21,6 +21,17 @@ fun ParametrizedWithType.java8Home(os: Os) { | |||
| param("env.JAVA_HOME", "%${os.name}.java8.oracle.64bit%") | |||
| } | |||
There was a problem hiding this comment.
Do we still need java8Home()? If so, I think it call through to javaHome().
| @@ -7,6 +7,7 @@ fun Project.configureGradleProfilerProject() { | |||
| buildType(MacOSJava18) | |||
| buildType(WindowsJava18) | |||
| buildType(LinuxJava18) | |||
| buildType(LinuxJava11) | |||
There was a problem hiding this comment.
I think this would be a good opportunity to rename Java18 to Java8.
There was a problem hiding this comment.
I can do this post-merge, so I still run the tests on my branch. Renaming the object causes a change in the ID in Teamcity, so I can't do this change on a branch.
| @@ -8,18 +10,40 @@ abstract class AbstractProfilerIntegrationTest extends AbstractIntegrationTest { | |||
|
|
|||
| private static int NUMBER_OF_HEADERS = 4 | |||
|
|
|||
| static List<String> supportedOnCurrentJvm(List<String> gradleVersions) { | |||
There was a problem hiding this comment.
How about calling this gradleVersionsSupportedOnCurrentJvm()?
| @@ -1349,7 +1354,7 @@ buildGoal { | |||
| def scenarios = file("performance.scenario") | |||
| scenarios.text = """ | |||
| buildTarget { | |||
| versions = ["4.5"] | |||
| versions = ["5.2"] | |||
There was a problem hiding this comment.
Because 4.5 doesn't work with Java 11.
|
@lptr PTAL! |
This reverts commit 63366db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.