Consolidate file layout for profiles and flame graphs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. like: ├── 5.2.1-allocation-raw-flames.svg ├── 5.2.1-allocation-raw-icicles.svg ├── 5.2.1-allocation-raw-stacks.txt ├── 5.2.1-allocation-simplified-flames.svg ├── 5.2.1-allocation-simplified-icicles.svg ├── 5.2.1-allocation-simplified-stacks.txt ├── 5.2.1-cpu-raw-flames.svg ├── 5.2.1-cpu-raw-icicles.svg ├── 5.2.1-cpu-raw-stacks.txt ├── 5.2.1-cpu-simplified-flames.svg ├── 5.2.1-cpu-simplified-icicles.svg ├── 5.2.1-cpu-simplified-stacks.txt ├── 5.2.1-monitor-blocked-raw-flames.svg ├── 5.2.1-monitor-blocked-raw-icicles.svg ├── 5.2.1-monitor-blocked-raw-stacks.txt ├── 5.2.1-monitor-blocked-simplified-flames.svg ├── 5.2.1-monitor-blocked-simplified-icicles.svg ├── 5.2.1-monitor-blocked-simplified-stacks.txt ├── 5.2.1.jfr └── profile.log
So they are similar to the JFR profiler outputs.
blindpirate
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the JFR profiler will generate a deeply nested structure of flame graphs, while async profiler puts all the flame graphs in one directory. We now consolidate this to end up with all the flame graphs in the scenario output directory:
We also include the event and the type in the file names for async profiler, so those will be the same as well.