-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create differential flame graphs for async-profiler or JFR #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the `difffolded.pl` script from https://github.com/brendangregg/FlameGraph/blob/a258e78f17abdf2ce21c2515cfe8306a44774e2a/difffolded.pl
Move the more general code to the flamegraphs package and leave only the conversion from jfr files to stacks in the jfr package.
wolfs
changed the title
Create differential flame graphs for async of JFR profilers
Create differential flame graphs for async-profiler or JFR
Mar 22, 2021
blindpirate
reviewed
Mar 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left a few comments, it looks great overall.
src/test/groovy/org/gradle/profiler/DifferentialFlameGraphIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
1ns created too much overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using async-profiler or JFR we can generate differential flame graphs for the stack files generated during "regular" profiling. This changes creates the differential flame graphs at the end of the profile runs, if