Sign artifacts for publishing #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindpirate
reviewed
Jul 27, 2021
| @@ -37,3 +38,18 @@ fun Project.gradleInternalRepositoryUrl(): URI { | |||
| val repositoryQualifier = if (isSnapshot) "snapshots" else "releases" | |||
| return uri("https://repo.gradle.org/gradle/ext-$repositoryQualifier-local") | |||
| } | |||
|
|
|||
| val signArtifacts: Boolean = !System.getenv("PGP_SIGNING_KEY").isNullOrEmpty() | |||
There was a problem hiding this comment.
Shall we use providers.environmentVariable("...").forUseAtConfigurationTime().orNull?
| @@ -22,6 +24,8 @@ object GradleProfilerPublishing : BuildType({ | |||
| param("env.ORG_GRADLE_PROJECT_sdkmanToken", "%gradleprofiler.sdkman.token%") | |||
| param("env.GRADLE_CACHE_REMOTE_USERNAME", "%gradle.cache.remote.username%") | |||
| param("env.GRADLE_CACHE_REMOTE_PASSWORD", "%gradle.cache.remote.password%") | |||
| param("env.PGP_SIGNING_KEY", "%pgpSigningKey%") | |||
There was a problem hiding this comment.
Personally I like storing these credentials in TC parameters so that they can be updated without changing code, wdyt?
There was a problem hiding this comment.
That is a good point. I stored it for now like this, since I don't want to define the pgpSigning key in the root project, which would essentially allow all builds to access it. I did the same for native platform. Let's revisit this later.
There was a problem hiding this comment.
If pgp signing key is used only in gradle-profiler, why don't define it in gradle-profiler TC project?
|
@blindpirate PTAL! |
blindpirate
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.