Move Android Studio related code out of GradleScenarioInvoker and rel… #374
Conversation
asodja
force-pushed
the
asodja/after-studio-refactoring
branch
from
9b641db
to
343f2a6
Compare
asodja
force-pushed
the
asodja/after-studio-refactoring
branch
from
343f2a6
to
659a68a
Compare
asodja
force-pushed
the
asodja/after-studio-refactoring
branch
from
659a68a
to
4777180
Compare
src/main/java/org/gradle/profiler/studio/invoker/StudioSample.java
Outdated
Show resolved
Hide resolved
| GRADLE_EXECUTION_TIME("Gradle execution time") { | ||
| @Override | ||
| public Duration extractFrom(BuildInvocationResult result) { | ||
| StudioBuildActionResult studioResult = (StudioBuildActionResult) result.getActionResult(); |
There was a problem hiding this comment.
We don't want to introduce a StudioBuildInvocationResult to avoid this cast?
There was a problem hiding this comment.
That would be ideal, but it requires some changes, I will check what I can do.
There was a problem hiding this comment.
What I did: I created a StudioBuildInvocationResult, and I do a cast there. It's not totally perfect, but I think that right now that is the simplest and cleanest solution.
Otherwise, we would have to inject (or override some method that will return) a custom BuildUnderTestInvoker into GradleScenarioInvoker and also create a new InvokeAndMeasureAction that would return StudioBuildInvocationResult. Additionally to that, BuildAction would have to return generic result from run method and that would require passing generics everywhere and it will get a bit messy.
I would try to avoid that. WDYT?
asodja
force-pushed
the
asodja/after-studio-refactoring
branch
from
7528009
to
b8f6c61
Compare
asodja
force-pushed
the
asodja/after-studio-refactoring
branch
from
b8f6c61
to
71a64c3
Compare
…ated classes
So yeah, I did not introduce generics to BuildAction at the moment since this can complicate things. So right now I just wrap Gradle invoker logic and enhance samples, here is some casting involved that might not be that nice (in
StudioSampleclass), but it makes a solution simpler.Fixes: #371