Use absolute paths for async-profiler output files #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing Android Studio sync with gradle-profiler I noticed after a long debugging session that profiler does not work if absolute --output-dir is not set. This fixes it so absolute paths are passed in JVM args.
wolfs
reviewed
Dec 14, 2021
| @@ -34,7 +34,7 @@ public static AsyncProfilerOutputType from(AsyncProfilerConfig config, GradleSce | |||
| abstract File outputFileFor(ScenarioSettings settings); | |||
|
|
|||
| File individualOutputFileFor(ScenarioSettings settings) { | |||
| File outputFile = outputFileFor(settings); | |||
| File outputFile = outputFileFor(settings).getAbsoluteFile(); | |||
There was a problem hiding this comment.
I think it would be better if outputFileFor would return an absolute file already.
There was a problem hiding this comment.
Done.
I also tested jfr, YourKit, JProfiler and they don't have this issue.
wolfs
reviewed
Dec 14, 2021
| @@ -9,13 +9,13 @@ | |||
| STACKS("collapsed") { | |||
| @Override | |||
| File outputFileFor(ScenarioSettings settings) { | |||
| return settings.profilerOutputLocationFor(".stacks.txt"); | |||
| return settings.profilerOutputLocationFor(".stacks.txt").getAbsoluteFile(); | |||
There was a problem hiding this comment.
I wonder if we should go even deeper: It seems like ScenarioDefinition.getOutputDir() or ScenarioDefinition.outputDir should always be an absolute file. Then the rest would follow automatically I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing Android Studio sync with gradle-profiler I noticed after a long debugging session that profiler does not work if absolute --output-dir is not set. This fixes it so absolute paths are passed in JVM args.