Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically install Android SDK on CI #386

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Conversation

asodja
Copy link
Member

@asodja asodja commented Dec 21, 2021

To avoid test failures on fresh agents without Android SDK.

@asodja asodja self-assigned this Dec 21, 2021
@asodja asodja requested a review from wolfs December 21, 2021 12:43
@asodja asodja added @execution internal Internal change labels Dec 21, 2021
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I am a little bit worried about the input declarations, since I think we'd end up snapshotting a lot.

buildSrc/src/main/kotlin/tasks/InstallAndroidSdkTask.kt Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asodja asodja merged commit ce8ff8e into master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants