Add support for running YourKit on Windows #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Snyder <sam@moderne.io>
asodja
reviewed
Mar 4, 2022
| @@ -35,6 +37,12 @@ public static File findControllerJar() { | |||
|
|
|||
| public static File findJniLib() { | |||
| File yourKitHome = findYourKitHome(); | |||
| if(OperatingSystem.isWindows()) { | |||
| if("32".equals(System.getProperty("sun.arch.data.model"))) { | |||
There was a problem hiding this comment.
Can we use "os.arch" instead of "sun.arch.data.model"? "sun.arch.data.model" seems to be tied to sun so I am not sure if all JVMs report that property.
I think having a method like OperatingSystem.isLinuxX86() but for windows would make sense.
There was a problem hiding this comment.
On second thought, I don't think we need to support 32bit.
There was a problem hiding this comment.
@sambsnyd Or you maybe need support for 32bit?
asodja
changed the title
|
Verified on Windows 64bit. |
|
Thank you for your contribution! I merged it, if you need any change, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.