Add support for Android Studio Chipmunk (2021.2), Dolphin (2021.3), Electric Eel (2022.1) and IntelliJ with Java17 runtime #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asodja
force-pushed
the
asodja/android-studio-ee
branch
3 times, most recently
from
7ee9f1d
to
14f6378
Compare
asodja
force-pushed
the
asodja/android-studio-ee
branch
5 times, most recently
from
4c4cc26
to
aa0187c
Compare
… add support for IntelliJ with Java 17 runtime
asodja
force-pushed
the
asodja/android-studio-ee
branch
from
aa0187c
to
711a090
Compare
lptr
reviewed
Aug 9, 2022
src/main/java/org/gradle/profiler/studio/launcher/LauncherConfigurationParser.java
Show resolved
Hide resolved
...in/src/main/java/org/gradle/profiler/studio/plugin/GradleProfilerProjectManagerListener.java
Show resolved
Hide resolved
...udio-plugin/src/main/java/org/gradle/profiler/studio/plugin/client/GradleProfilerClient.java
Outdated
Show resolved
Hide resolved
...udio-plugin/src/main/java/org/gradle/profiler/studio/plugin/client/GradleProfilerClient.java
Outdated
Show resolved
Hide resolved
| // but it doesn't return error message so we rather listen to GRADLE_SYNC_TOPIC to get the sync result | ||
| ProjectSystemUtil.getSyncManager(project).syncProject(ProjectSystemSyncManager.SyncReason.USER_REQUEST).get(); | ||
| } catch (InterruptedException | ExecutionException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Should we still call synclistener.syncFailed() here, or is it okay to just throw?
There was a problem hiding this comment.
Maybe it's better to call sync failed, to not crash our plugin, changed
There was a problem hiding this comment.
We are now back to throwing an exception instead of syncListener.failed(), is this intentional?
There was a problem hiding this comment.
Hmm, it seems github is showing outdated version here. Current version is here:
https://github.com/gradle/gradle-profiler/pull/439/files#diff-8eb36c0b3730fb2241bb7c46b8367c29778fcf7971216d69e1fb5df5d9938d1e
...plugin/src/main/java/org/gradle/profiler/studio/plugin/system/AndroidStudioSystemHelper.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/gradle/profiler/studio/plugin/system/GradleProfilerGradleSyncListener.java
Outdated
Show resolved
Hide resolved
...-plugin/src/test/groovy/org/gradle/profiler/studio/plugin/StudioPluginIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...-plugin/src/test/groovy/org/gradle/profiler/studio/plugin/StudioPluginIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...-plugin/src/test/groovy/org/gradle/profiler/studio/plugin/StudioPluginIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
asodja
force-pushed
the
asodja/android-studio-ee
branch
from
cade1ea
to
75efc92
Compare
lptr
reviewed
Aug 12, 2022
...plugin/src/main/java/org/gradle/profiler/studio/plugin/system/AndroidStudioSystemHelper.java
Outdated
Show resolved
Hide resolved
...-plugin/src/test/groovy/org/gradle/profiler/studio/plugin/StudioPluginIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
asodja
force-pushed
the
asodja/android-studio-ee
branch
from
2393822
to
74adecd
Compare
asodja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and IntelliJ with Java17 runtime.
Fixes #437