Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings after Gradle 7.5 update #444

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

nevack
Copy link
Contributor

@nevack nevack commented Aug 28, 2022

These changes are trivial.

This feature is marked as stable starting with Gradle 7.4.
There's no need to enable it manually.

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
This is no longer needed with Gradle 7.4+

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
This plugin issues a warning, if there's new version available.

Release Notes:
https://github.com/JetBrains/gradle-intellij-plugin/releases/tag/v1.8.1

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
@nevack
Copy link
Contributor Author

nevack commented Aug 28, 2022

Signed Off all commits

@asodja
Copy link
Member

asodja commented Aug 29, 2022

Hi @nevack,

thanks for the contribution! It looks good, except that we still have to build for Java8. Due to that could you drop the last commit and force push it again?

JDK11 is required for building a project since org.jetbrains.intellij plugin that is used in studio-plugin project is compiled for Java11. But studio-plugin is not used directly by the profiler, but it's used by Android Studio when you profile project sync with Android Studio.

@nevack
Copy link
Contributor Author

nevack commented Aug 29, 2022

That's what I expected and this is the reason this change is in the last commit - to drop it if it's not right.
Thanks for clarification.

Maybe it's worth mentioning in README that you need both JDK 8 and JDK 11 to build the project?

@asodja
Copy link
Member

asodja commented Aug 29, 2022

Thanks! Yeah, if you would like to update that, feel free to do so.

@asodja asodja merged commit 853779e into gradle:master Aug 31, 2022
@asodja
Copy link
Member

asodja commented Aug 31, 2022

Thanks for the contribution!

@asodja asodja added the internal Internal change label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants