Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Annotate Action<T> as a Kotlin extension function type #155

Closed
5 tasks done
bamboo opened this issue Oct 13, 2016 · 5 comments
Closed
5 tasks done

Annotate Action<T> as a Kotlin extension function type #155

bamboo opened this issue Oct 13, 2016 · 5 comments
Assignees
@bamboo
Labels
a:feature in:gradle-api in:kotlin-dsl-runtime is:blocked re:groovy-parity
Milestone
0.8.0

Comments

@bamboo
Copy link
Member

bamboo commented Oct 13, 2016 •
edited

  • Create a new HasImplicitReceiver annotation in Gradle core
  • Annotate Action<T> with HasImplicitReceiver
  • Register HasImplicitReceiver annotation with the SAMWithReceiver Kotlin compiler plugin in GSK
  • Remove gradle-api instrumentation and T.() -> Unit api extension generation
  • Remove any obsolete extensions that we might have
@bamboo bamboo added this to the 0.5.0 milestone Oct 13, 2016
@bamboo
Copy link
Member Author

bamboo commented Oct 13, 2016

Blocked by #156

This was referenced Oct 13, 2016
Closed
Closed
Closed
Closed
@bamboo bamboo modified the milestones: 0.6.0, 0.5.0 Oct 21, 2016
@bamboo bamboo mentioned this issue Nov 7, 2016
Closed
@bamboo bamboo modified the milestones: 0.6.0, 1.0.0 Nov 24, 2016
@bamboo bamboo modified the milestones: 0.7.0, 1.0.0 Jan 6, 2017
@bamboo bamboo mentioned this issue Jan 6, 2017
Closed
3 tasks
@bamboo bamboo self-assigned this Jan 7, 2017
@bamboo
Copy link
Member Author

bamboo commented Jan 7, 2017

Blocked: waiting for further instructions - https://kotlinlang.slack.com/archives/scripting/p1483797366000740

@bamboo
Copy link
Member Author

bamboo commented Jan 11, 2017

Provided a self-contained repro project to Yan Zhulanov from JetBrains for investigation: https://github.com/bamboo/kotlin-sam-with-receiver-repro

@bamboo bamboo modified the milestones: 0.8.0, 0.7.0 Jan 16, 2017
@bamboo
Copy link
Member Author

bamboo commented Jan 19, 2017

It should be fixed in the beta: https://blog.jetbrains.com/kotlin/2017/01/kotlin-1-1-beta-is-here

@bamboo
Copy link
Member Author

bamboo commented Jan 19, 2017

@ParameterExtension renamed to @HasImplicitReceiver in gradle/gradle@9ead5d8.

bamboo added a commit that referenced this issue Jan 19, 2017
@bamboo
Handle HasImplicitReceiver annotation via Kotlin compiler plugin
246ccff 
See #155
bamboo added a commit that referenced this issue Jan 19, 2017
@bamboo
Fix build script (now) invalid usage of Action<T> lambda parameters
b55d5a9 
See #155
bamboo added a commit that referenced this issue Jan 19, 2017
@bamboo
Remove unnecessary extensions from hello-android sample
40bad6b 
See #155
@bamboo bamboo mentioned this issue Jan 20, 2017
Merged
@bamboo bamboo closed this as completed Jan 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bamboo bamboo

Labels
a:feature in:gradle-api in:kotlin-dsl-runtime is:blocked re:groovy-parity
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@bamboo