Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Add missing Action<T> overloads to org.gradle.api.Project #122

Closed
bamboo opened this issue Sep 7, 2016 · 7 comments
Closed

Add missing Action<T> overloads to org.gradle.api.Project #122

bamboo opened this issue Sep 7, 2016 · 7 comments

Comments

@bamboo
Copy link
Member

bamboo commented Sep 7, 2016

The following methods are missing a Action<T> or Spec<T> counterpart:

org.gradle.api.Project#task(java.util.Map, java.lang.String, groovy.lang.Closure)
org.gradle.api.Project#task(java.lang.String, groovy.lang.Closure)
org.gradle.api.Project#project(java.lang.String, groovy.lang.Closure)
org.gradle.api.Project#files(java.lang.Object, groovy.lang.Closure)
org.gradle.api.Project#fileTree(java.lang.Object, groovy.lang.Closure)
org.gradle.api.Project#ant(groovy.lang.Closure)
org.gradle.api.Project#configurations(groovy.lang.Closure)
org.gradle.api.Project#artifacts(groovy.lang.Closure)
org.gradle.api.Project#repositories(groovy.lang.Closure)
org.gradle.api.Project#dependencies(groovy.lang.Closure)
org.gradle.api.Project#buildscript(groovy.lang.Closure)
org.gradle.api.Project#container(java.lang.Class, groovy.lang.Closure)
@bamboo bamboo added this to the 0.4.0 milestone Sep 7, 2016
@bamboo bamboo changed the title Introduce missing Action<T> overloads to org.gradle.api.Project Add missing Action<T> overloads to org.gradle.api.Project Sep 7, 2016
@bamboo bamboo modified the milestones: 0.4.0, 0.5.0 Sep 8, 2016
@eskatos eskatos self-assigned this Oct 25, 2016
@eskatos
Copy link
Member

eskatos commented Oct 25, 2016

org.gradle.api.Project#container(java.lang.Class, groovy.lang.Closure) already has a strongly typed counterpart org.gradle.api.Project#container(java.lang.Class<T>, org.gradle.api.NamedDomainObjectFactory<T>)

eskatos added a commit to gradle/gradle that referenced this issue Nov 3, 2016
eskatos added a commit to gradle/gradle that referenced this issue Nov 3, 2016
@eskatos
Copy link
Member

eskatos commented Nov 3, 2016

@bamboo I reverted the change because it was causing a failure I'd like to discuss with you when you get back, see https://builds.gradle.org/viewLog.html?buildId=1672517

@bamboo
Copy link
Member Author

bamboo commented Nov 7, 2016

Right. We need to wait until #155 is implemented.

@eskatos
Copy link
Member

eskatos commented Nov 8, 2016

Okay, I'll move this issue back in backlog then.

@eskatos
Copy link
Member

eskatos commented Feb 2, 2017

A first PR against Gradle adds overloads for all methods but repositories() and dependencies(): gradle/gradle#1284

For those two methods we have to wait for the @HasImplicitReceiver annotation to take effect as they would break the version of gradle-script-kotlin included in Gradle.

Changes to add those two overloads are in a separate branch:
https://github.com/gradle/gradle/tree/pm-action-overloads-project-missing

@eskatos
Copy link
Member

eskatos commented Feb 2, 2017

Removed the overload of Project#configure(Closure, Object) in master. That one too needs to wait.

Added on top of the pm-action-overloads-project-missing branch.

@bamboo bamboo modified the milestones: 1.0.0, 0.8.0 Feb 14, 2017
@bamboo
Copy link
Member Author

bamboo commented Feb 14, 2017

Remaining work moved to #262.

@bamboo bamboo closed this as completed Feb 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants