Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Replace ServiceRegistry by @Inject based DI on ScriptPluginFactoryProvider SPI #87

Closed
bamboo opened this issue Jul 5, 2016 · 0 comments

Comments

@bamboo
Copy link
Member

bamboo commented Jul 5, 2016

There are two main reasons for it:

  • ServiceRegistry is an internal interface and as such it should not be part of an API
  • to make all dependencies explicit at the KotlinScriptPluginFactoryProvider level

In order to evolve the SPI interface without binary breakage:

  1. introduce new method on core SPI but don't call it just yet
  2. implement the new method on gsk and ship new minor release
  3. update core to new gsk release and call the new method
    • remove old method and ship new nightly (breaks source gsk compatibility!)
    • update gradle/gradle-script-kotlin branch to latest gradle
  4. remove old implementation from gsk when new core nightly comes out
@bamboo bamboo added this to the 0.3.0 milestone Jul 5, 2016
@bamboo bamboo self-assigned this Jul 6, 2016
bamboo added a commit to gradle/gradle that referenced this issue Jul 7, 2016
…ryProvider` SPI

Step 1. introduce new method on SPI but don't call it just yet

See gradle/kotlin-dsl-samples#87
bamboo added a commit that referenced this issue Jul 8, 2016
bamboo added a commit to gradle/gradle that referenced this issue Jul 11, 2016
By upgrading gradle-script-kotlin to 0.2.1 which conforms to the new DI
semantics.

See gradle/kotlin-dsl-samples#87
@bamboo bamboo closed this as completed in d93cfbf Jul 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant