Skip to content

Commit

Permalink
Remove deprecated internal constructor
Browse files Browse the repository at this point in the history
  • Loading branch information
jjohannes committed Nov 23, 2017
1 parent db7b53f commit e7bfc5f
Showing 1 changed file with 0 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,11 @@
import org.gradle.api.artifacts.PublishArtifact;
import org.gradle.api.attributes.AttributeContainer;
import org.gradle.api.attributes.Usage;
import org.gradle.api.internal.attributes.DefaultImmutableAttributesFactory;
import org.gradle.api.internal.attributes.ImmutableAttributes;
import org.gradle.api.internal.attributes.ImmutableAttributesFactory;
import org.gradle.api.internal.component.SoftwareComponentInternal;
import org.gradle.api.internal.component.UsageContext;
import org.gradle.api.internal.model.DefaultObjectFactory;
import org.gradle.api.internal.model.NamedObjectInstantiator;
import org.gradle.api.model.ObjectFactory;
import org.gradle.internal.reflect.DirectInstantiator;

import javax.inject.Inject;
import java.util.LinkedHashSet;
Expand All @@ -45,10 +41,6 @@
* A SoftwareComponent representing a library that runs on a java virtual machine.
*/
public class JavaLibrary implements SoftwareComponentInternal {

// This must ONLY be used in the deprecated constructor, for backwards compatibility
private final static ObjectFactory DEPRECATED_OBJECT_FACTORY = new DefaultObjectFactory(DirectInstantiator.INSTANCE, NamedObjectInstantiator.INSTANCE);

private final Set<PublishArtifact> artifacts = new LinkedHashSet<PublishArtifact>();
private final UsageContext runtimeUsage;
private final UsageContext compileUsage;
Expand All @@ -66,20 +58,6 @@ public JavaLibrary(ObjectFactory objectFactory, ConfigurationContainer configura
this.compileUsage = new CompileUsageContext(Usage.JAVA_API);
}

/**
* This constructor should not be used, and is maintained only for backwards
* compatibility with the widely used Shadow plugin.
*/
@Deprecated
public JavaLibrary(PublishArtifact jarArtifact, DependencySet runtimeDependencies) {
this.artifacts.add(jarArtifact);
this.objectFactory = DEPRECATED_OBJECT_FACTORY;
this.attributesFactory = new DefaultImmutableAttributesFactory(null);
this.runtimeUsage = new BackwardsCompatibilityUsageContext(Usage.JAVA_RUNTIME, runtimeDependencies);
this.compileUsage = new BackwardsCompatibilityUsageContext(Usage.JAVA_API, runtimeDependencies);
this.configurations = null;
}

@VisibleForTesting
Set<PublishArtifact> getArtifacts() {
return artifacts;
Expand Down Expand Up @@ -156,23 +134,4 @@ public Set<ModuleDependency> getDependencies() {
return dependencies.withType(ModuleDependency.class);
}
}

private class BackwardsCompatibilityUsageContext extends AbstractUsageContext {
private final DependencySet runtimeDependencies;

private BackwardsCompatibilityUsageContext(String usageName, DependencySet runtimeDependencies) {
super(usageName);
this.runtimeDependencies = runtimeDependencies;
}

@Override
public String getName() {
return getUsage().getName();
}

@Override
public Set<ModuleDependency> getDependencies() {
return runtimeDependencies.withType(ModuleDependency.class);
}
}
}

0 comments on commit e7bfc5f

Please sign in to comment.