Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show path of hs_err_pid file when daemon disappears #12345

Closed
mathjeff opened this issue Feb 25, 2020 · 1 comment · Fixed by #12386
Closed

Show path of hs_err_pid file when daemon disappears #12345

mathjeff opened this issue Feb 25, 2020 · 1 comment · Fixed by #12386
Assignees
Labels
a:feature A new functionality
Milestone

Comments

@mathjeff
Copy link
Contributor

Expected Behavior

When the Gradle daemon crashes, it would be great if the Gradle client would print the filepath of the hs_pid_file generated by the Gradle daemon (assuming that that file exists).
It would also be nice to print the first ~80 lines of that file too.

Current Behavior

Currently when the Gradle daemon crashes, the Gradle client doesn't mention the existence of an hs_err_pid file to the user.

Context

The AndroidX team has been observing our Gradle daemon to be crashing itermittently : http://issuetracker.google.com/issues/146217083 . Because our crashes occur nearly exclusively on continuous integration servers, we don't see the hs_err_pid files when they are generated (they're created in the working directory from which Gradle was executed, which is a directory that we otherwise wouldn't need to inspect).

However, we found it was super useful to inspect the hs_err_pid file: http://issuetracker.google.com/issues/146217083#comment39 .

If Gradle would display the filepath of the hs_err_pid file, it would be easier for developers to think to look for it and to make sure that the builder copies it into a location where it will be visible after the build completes.

Thanks

@mathjeff mathjeff added a:feature A new functionality from:contributor labels Feb 25, 2020
@wolfs wolfs added this to the 6.3 RC1 milestone Feb 28, 2020
@wolfs wolfs self-assigned this Feb 28, 2020
@mathjeff
Copy link
Contributor Author

mathjeff commented Mar 2, 2020

Thanks for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants