Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local consistency resolution: do not resolve when doing partial resolution #15588

Closed
ljacomet opened this issue Dec 15, 2020 · 1 comment
Closed

Local consistency resolution: do not resolve when doing partial resolution #15588

ljacomet opened this issue Dec 15, 2020 · 1 comment
Labels
a:bug in:dependency-management DO NOT USE
Milestone
6.8 RC3

Comments

@ljacomet
Copy link
Member

During the configuration phase of Gradle, configurations are resolved with a filter that only looks at projects.
In that case we should not trigger consistent resolution and wait until full resolution happens.
@ljacomet ljacomet added this to the 6.8 RC2 milestone Dec 15, 2020
melix added a commit that referenced this issue Dec 15, 2020
@melix
Fix source of consistent resolution being eagerly resolved
37decb5 
This commit fixes an issue with consistent resolution, which caused
the consistent resolution source to be fully resolved (including
external dependencies) during task dependencies computation.

To fix this problem, we reworked how "synthetic" dependencies are
added to the resolution process. Synthetic dependencies include
dependency locking constraints, as well as constraints for
dependency resolution consistency. They would now only be added
to the resolution graph if we're actually at the execution phase,
not during task dependency computation.

Fixes #15588
@melix melix mentioned this issue Dec 15, 2020
Merged
13 tasks
@ljacomet
Copy link
Member Author

#15593 has been merged, closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:dependency-management DO NOT USE
Projects
None yet
Milestone
6.8 RC3
Development

No branches or pull requests
1 participant
@ljacomet