Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK 18 #19283

Closed
sormuras opened this issue Dec 10, 2021 · 7 comments · Fixed by #20268 or #20339
Closed

Support JDK 18 #19283

sormuras opened this issue Dec 10, 2021 · 7 comments · Fixed by #20268 or #20339
Assignees
Labels
a:feature A new functionality @core Issue owned by GBT Core in:invoking-gradle Running Executing in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures
Milestone

Comments

@sormuras
Copy link

sormuras commented Dec 10, 2021

As mentioned in #18465 (comment) an upgrade to ASM 9.2 is required to support scanning/parsing/reading classes compiled to Java 18.

@sormuras sormuras added a:feature A new functionality to-triage labels Dec 10, 2021
@big-guy big-guy added in:invoking-gradle Running Executing in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures and removed to-triage labels Dec 10, 2021
@big-guy big-guy added this to the 7.5 RC1 milestone Dec 10, 2021
@ice1000
Copy link

ice1000 commented Mar 14, 2022

It's now a week before JDK 18 GA :)

@big-guy big-guy added the @core Issue owned by GBT Core label Mar 15, 2022
@octylFractal octylFractal self-assigned this Mar 15, 2022
@octylFractal
Copy link
Member

octylFractal commented Mar 18, 2022

Keeping track of the issues with console encoding (these stem from the console default charset no longer aligning with Charset.defaultCharset()):

  • Need unicode output tests for the following:
    • TestKit
    • Test task
    • JVM metadata detection
    • GCC metadata detection
    • TODO find more places we capture console output with the default encoding.

Edit: see #20267 for more details. These items won't be fixed when this issue is closed.

@big-guy
Copy link
Member

big-guy commented Mar 31, 2022

We still need to add JDK18 to compatibility guide, release notes and release features

@sormuras
Copy link
Author

sormuras commented Apr 6, 2022

Fine!

Now, on to #20372

@danielpeintner
Copy link

We still need to add JDK18 to compatibility guide, release notes and release features

I think updates to Compatibility Matrix are still missing...
https://docs.gradle.org/current/userguide/compatibility.html

If you are aware of it and want to wait for the official 7.5 release it is fine..

@octylFractal
Copy link
Member

octylFractal commented Apr 6, 2022

I'm not sure what you mean, the code is updated (source), but that page isn't because it's 7.4.2, not the latest nightly. It seems like the nightly docs aren't updated because the nightly failed to build is not built yet, but the change is for sure in master already.

@danielpeintner
Copy link

What I meant was that the website is not yet showing the update but that might be because 7.5.x has not been officially published. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality @core Issue owned by GBT Core in:invoking-gradle Running Executing in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants