Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Groovy to 3.0.10 #20177

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Update Groovy to 3.0.10 #20177

merged 2 commits into from
Mar 22, 2022

Conversation

octylFractal
Copy link
Member

@octylFractal octylFractal commented Mar 14, 2022 •
edited

Required for JDK 18 support. Partial work on #19283.

@octylFractal octylFractal added this to the 7.5 RC1 milestone Mar 14, 2022
@octylFractal octylFractal requested a review from a team March 14, 2022 17:09
@octylFractal octylFractal self-assigned this Mar 14, 2022
DPUkyle
DPUkyle approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@DPUkyle DPUkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octylFractal
Copy link
Member Author

Waiting on javaparser/javaparser#3516.

@big-guy
Copy link
Member

big-guy commented Mar 15, 2022

@octylFractal could you see if GroovyCoverage also needs to be updated?

@octylFractal
Copy link
Member Author

GroovyCoverage uses the current version + a list of previous ones. No other 3.0.x is listed here, so I don't think there's a reason to add one, unless you would like to start doing so to be sure we cover all patch versions.

@big-guy big-guy added the @core Issue owned by GBT Core label Mar 15, 2022
@big-guy
Copy link
Member

big-guy commented Mar 15, 2022

Hrm, there probably should have been a 3.0.x at some point. Don't worry about it now

@ice1000
Copy link

ice1000 commented Mar 15, 2022

Nice!!

@ice1000
Copy link

ice1000 commented Mar 15, 2022

Waiting on javaparser/javaparser#3516.

HOw is that issue blocking this? Aren't all checks passed here?

@octylFractal
Copy link
Member Author

It's a security concern, related to #20177 (comment) -- I am unsure if the change is intentional, and if it wasn't, then it could be a sign of malicious code. Obviously we prefer not to distribute malicious code :)

@ice1000
Copy link

ice1000 commented Mar 15, 2022

Thanks!! Sounds great!!

@ice1000 ice1000 mentioned this pull request Mar 19, 2022
Closed
@ice1000
Copy link

ice1000 commented Mar 20, 2022

javaparser/javaparser#3516 (comment)

@ice1000
Copy link

ice1000 commented Mar 20, 2022

I think nothing's blocking this now, right? 😉😉😉😉😉

@octylFractal
Copy link
Member Author

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

Error while scheduling pre-tested commit, please contact the administrator.

@octylFractal
Copy link
Member Author

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 625c084 into master Mar 22, 2022
@ice1000
Copy link

ice1000 commented Mar 22, 2022

Noice

@blindpirate blindpirate deleted the ot/feature/jdk-18 branch March 23, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DPUkyle DPUkyle DPUkyle approved these changes

Assignees

@octylFractal octylFractal

Labels
@core Issue owned by GBT Core
Projects
None yet
Milestone
7.5 RC1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@octylFractal @big-guy @ice1000 @bot-gradle @DPUkyle