test-report-aggregation docs are missing mention of --continue flag
#22013
Assignees
Labels
a:bug
@core
Issue owned by GBT Core
in:documentation
DO NOT USE
in:test-suites
Work related to the JvmTestSuite Plugin
Milestone
Comments
DPUkyle
added
a:bug
to-triage
in:test-suites
13 tasks
|
I don't think this quite covers it. Please also mention this option on the jacoco_report_aggregation_plugin.adoc and test_report_aggregation_plugin.adoc pages. |
|
@DPUkyle can you take a look at the PR again? The PR wasn't final when you looked at it yesterday, those pages are now covered. |
bot-gradle
added a commit
that referenced
this issue
Sep 21, 2022
<!--- The issue this PR addresses --> #22013 ### Context Rendered docs: [Jacaco Report Aggregation Plugin](https://builds.gradle.org/repository/download/Gradle_Release_Check_BuildDistributions/56314133:id/distributions/gradle-7.6-docs.zip!/gradle-7.6-20220921034436%2B0000/docs/userguide/jacoco_report_aggregation_plugin.html#reports) [Test Report Aggregation Plugin](https://builds.gradle.org/repository/download/Gradle_Release_Check_BuildDistributions/56314133:id/distributions/gradle-7.6-docs.zip!/gradle-7.6-20220921034436%2B0000/docs/userguide/test_report_aggregation_plugin.html#reports) [CLI](https://builds.gradle.org/repository/download/Gradle_Release_Check_BuildDistributions/56314133:id/distributions/gradle-7.6-docs.zip!/gradle-7.6-20220921034436%2B0000/docs/userguide/command_line_interface.html#sec:continue_build_on_failure) ### Contributor Checklist - [X] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/CONTRIBUTING.md) - [X] Make sure that all commits are [signed off](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff) to indicate that you agree to the terms of [Developer Certificate of Origin](https://developercertificate.org/). - [X] Make sure all contributed code can be distributed under the terms of the [Apache License 2.0](https://github.com/gradle/gradle/blob/master/LICENSE), e.g. the code was written by yourself or the original code is licensed under [a license compatible to Apache License 2.0](https://apache.org/legal/resolved.html). - [X] Check ["Allow edit from maintainers" option](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) in pull request so that additional changes can be pushed by Gradle team - [X] Provide integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective - [X] Provide unit tests (under `<subproject>/src/test`) to verify logic - [X] Update User Guide, DSL Reference, and Javadoc for public-facing changes - [X] Ensure that tests pass sanity check: `./gradlew sanityCheck` - [X] Ensure that tests pass locally: `./gradlew <changed-subproject>:quickTest` ### Gradle Core Team Checklist - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation - [ ] Recognize contributor in release notes Co-authored-by: nate contino <ncontino@protonmail.com>
|
Addressed! |
This was referenced Jan 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As evidenced by #21966, our docs are completely missing any mention of the
--continueflag, which is necessary to allow aggregation to proceed despite broken tests.We should update these two pages:
The text was updated successfully, but these errors were encountered: