7.6 RC3: DependencyAdder.invoke cannot be called with the arguments supplied

[ianbrandt]

Expected Behavior

Precompiled script plugins configuring a project dependency for an additional test suite via the JVM Test Site Plugin continue to compile after upgrading to Gradle 7.6 RC3.

Current Behavior

The script fails to compile:

e: C:\Dev\Repos\SDKotlin\sd-kotlin-talks\build-logic\src\main\kotlin\org.sdkotlin.build.test.integration-test-suite.gradle.kts: (20, 5): None of the following functions can be called with the arguments supplied: 
public operator fun DependencyAdder.invoke(dependencyNotation: CharSequence): Unit defined in org.gradle.kotlin.dsl
public operator fun DependencyAdder.invoke(dependency: Dependency): Unit defined in org.gradle.kotlin.dsl
public operator fun DependencyAdder.invoke(files: FileCollection): Unit defined in org.gradle.kotlin.dsl
public operator fun DependencyAdder.invoke(dependency: Provider<out Dependency>): Unit defined in org.gradle.kotlin.dsl
public operator fun DependencyAdder.invoke(externalModule: ProviderConvertible<out MinimalExternalModuleDependency>): Unit defined in org.gradle.kotlin.dsl

FAILURE: Build failed with an exception.

Context

I'm unable to upgrade to Gradle 7.6.

Steps to Reproduce

Reproducer: https://github.com/sdkotlin/sd-kotlin-talks/tree/a54afe81013c1806550ff23478efe48973033deb

Line in error: https://github.com/sdkotlin/sd-kotlin-talks/blob/a54afe81013c1806550ff23478efe48973033deb/build-logic/src/main/kotlin/org.sdkotlin.build.test.integration-test-suite.gradle.kts#L20

Your Environment

Gradle 7.6-rc3
Kotlin 1.7.21
Java 11.0.17

[tresat]

Hi Ian, this is an expected change to the @Incubating Test Suites API we're making with Gradle 7.6. This is part of an effort to make the API used to add dependencies more discoverable and strongly typed. It should have the benefit of making the testing DSL easier to work with in your IDE.

Take a look at the Introduced strongly-typed dependencies block for JVM test suites section in the release notes and the updated example in the JVM Test Suite Plugin page of the user guide. In short, you need to switch from referencing the current project via project to calling the project() method.

The methods used to add dependencies to Test Suites differ from those used in the top-level block. In Gradle 7.6, Test Suites make use of a new type DependencyAdder, which accepts a ProjectDependency, not a Project, as in the top-level dependencies block. You need to call the project() method to obtain one of these.

This is a subtle change, and definitely a possible stumbling block. Thanks for pointing it out! We'll add a note to the upgrade guide.

[ianbrandt]

Thanks @tresat, I was able to upgrade to 7.6 RC3 successfully using project() instead of project.

[bric3]

For people discovering this issue with versions catalog items, you need to change the declarations this way

  testing {
      suites {
          val test by getting(JvmTestSuite::class) {
              useJUnitJupiter(libs.versions.junit.jupiter.get())
              dependencies {
-                 implementation(libs.assertj)
+                 implementation.add(libs.assertj)
-                 implementation(libs.bundles.batik)
+                 implementation.bundle(libs.bundles.batik)
              }
          }

To find the relevant method, inspect DependencyAdder doc.

As this isn't clearly explained in neither the release note nor the differences doc. There's only a mention of the bundle lost in a long list. I believe some examples would have been better in this case.

[tresat]

As this isn't clearly explained in neither the release note nor the differences doc. There's only a mention of the bundle lost in a long list. I believe some examples would have been better in this case.

@bric3 - Finally got around to updating the docs here: #28828. Thank you for pointing this out!