Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nag for deprecation of BasePluginExtension members #22908

Closed
eskatos opened this issue Nov 30, 2022 · 1 comment · Fixed by #23813
Closed

Nag for deprecation of BasePluginExtension members #22908

eskatos opened this issue Nov 30, 2022 · 1 comment · Fixed by #23813
Assignees
@eskatos
Labels
a:chore Minor issue without significant impact in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures
Milestone
8.5 RC1

Comments

@eskatos
Copy link
Member

eskatos commented Nov 30, 2022 •
edited

  • String getDistsDirName();
  • void setDistsDirName(String distsDirName);
  • String getLibsDirName();
  • void setLibsDirName(String libsDirName);
  • String getArchivesBaseName();
  • void setArchivesBaseName(String archivesBaseName);

This should happen in 8.1 with a message that says it will become an error in 9.0.

Soft deprecated in 7.1 by

This can't be done until Kotlin plugin for android remove deprecated usages

PR with the added deprecation nagging
@eskatos eskatos added a:chore Minor issue without significant impact in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures labels Nov 30, 2022
@eskatos eskatos added this to the 8.1 RC1 milestone Nov 30, 2022
@eskatos eskatos self-assigned this Feb 4, 2023
@eskatos eskatos modified the milestones: 8.1 RC1, 8.2 RC1 Feb 4, 2023
@eskatos eskatos mentioned this issue Feb 7, 2023
Merged
@eskatos eskatos removed their assignment Feb 8, 2023
@eskatos eskatos modified the milestones: 8.2 RC1, 8.3 RC1 Apr 7, 2023
TWiStErRob added a commit to TWiStErRob/mockito that referenced this issue Jul 4, 2023
@TWiStErRob
Migrate from BasePluginExtension.getArchivesBaseName(): String to Bas…
e1e2656 
…ePluginExtension.getArchivesName(): Property<String>

There's no nagging for this ([yet](gradle/gradle#22908)), but it's scheduled for removal in Gradle 9.

JavaDoc: https://docs.gradle.org/7.1/javadoc/org/gradle/api/plugins/BasePluginExtension.html

Upgrade guide (7.0 to 7.1): https://docs.gradle.org/8.1/userguide/upgrading_version_7.html#base_convention_deprecation

Short note on syntax: in the Gradle property API .get() and .set() are required for updating the value of the property, except in Groovy build scripts where the accessor is clearly setting a property value. x.y = z is equivalent to x.y.set(z). Kotlin DSL will also make this possible soon.
@eskatos eskatos modified the milestones: 8.3 RC1, 8.4 RC1 Jul 12, 2023
@ljacomet ljacomet modified the milestones: 8.4 RC1, 8.5 RC1 Aug 28, 2023
@eskatos eskatos self-assigned this Oct 19, 2023
bot-gradle added a commit that referenced this issue Oct 20, 2023
@bot-gradle @eskatos
Merge pull request #23813 Log deprecations for old properties in `bas…
537ca3a 
…e.*` plugin extension

* Fixes #22908

Co-authored-by: Paul Merlin <paul@gradle.com>
@github-actions github-actions bot mentioned this issue Nov 29, 2023
Merged
@sebhoss sebhoss mentioned this issue Dec 3, 2023
Merged
This was referenced Dec 4, 2023
Merged
Closed
@github-actions github-actions bot mentioned this issue Dec 11, 2023
Merged
@github-actions github-actions bot mentioned this issue Jan 1, 2024
Merged
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Merged
@iiasceri
Copy link

And how to do it now? archivesBaseName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eskatos eskatos

Labels
a:chore Minor issue without significant impact in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures
Projects
None yet
Milestone
8.5 RC1
Development

Successfully merging a pull request may close this issue.

Log deprecations for old properties in base.* plugin extension gradle/gradle
3 participants
@eskatos @ljacomet @iiasceri