Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePermissions has a typo in the default unix value #25830

Closed
ben-manes opened this issue Jul 20, 2023 · 7 comments · Fixed by #25899 or #26232
Closed

FilePermissions has a typo in the default unix value #25830

ben-manes opened this issue Jul 20, 2023 · 7 comments · Fixed by #25899 or #26232
Assignees
Labels
a:documentation Documentation content good first issue Good for newcomers in:file-tasks copy sync zip tar rename delete
Milestone

Comments

@ben-manes
Copy link
Contributor

Issue type

Typo

Problem description

FILE: read & write for OWNER, read for GROUP, read for OTHER (0644, r-wr--r--)

This should be rw-r--r-- as it is rwx segments.

Context (optional)

This typo is listed in the guide and javadoc.

Page with the problem

https://docs.gradle.org/8.3-rc-1/userguide/working_with_files.html#sec:setting_file_permissions

@ben-manes ben-manes added a:documentation Documentation content to-triage labels Jul 20, 2023
@ov7a
Copy link
Member

ov7a commented Jul 21, 2023

Thank you for your interest in Gradle!

This is a valid documentation issue that we will address.


This issue is a good choice for first-time contributors to Gradle, it is actionable and ready for contribution.

See CONTRIBUTING.md for more information.

@ov7a ov7a added in:file-tasks copy sync zip tar rename delete good first issue Good for newcomers and removed to-triage labels Jul 21, 2023
@pratik2315
Copy link
Contributor

Hey! I would like to work on this issue :)

@ov7a
Copy link
Member

ov7a commented Jul 24, 2023

@pratik2315 Ok, thank you!

@bot-gradle bot-gradle added this to the 8.4 RC1 milestone Aug 1, 2023
@ben-manes
Copy link
Contributor Author

As stated twice before, please also fix the JavaDoc. The fix only changed the user manual.

* <li>FILE: read &amp; write for OWNER, read for GROUP, read for OTHER (0644, r-wr--r--)</li>

@ov7a
Copy link
Member

ov7a commented Aug 3, 2023

@pratik2315 Can you take care of this?

@ben-manes
Copy link
Contributor Author

fyi, 8.3 did not cherry-pick the user guide typo fix nor is the javadoc fixed.

ov7a added a commit that referenced this issue Aug 31, 2023
bot-gradle added a commit that referenced this issue Aug 31, 2023
Fixes #25830

Co-authored-by: Vlad Chesnokov <vchesnokov@gradle.com>
@ov7a
Copy link
Member

ov7a commented Aug 31, 2023

@ben-manes Yep, it would be included in 8.4 It's not severe enough to make the 8.3.1 release.
I've fixed the Javadoc typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:documentation Documentation content good first issue Good for newcomers in:file-tasks copy sync zip tar rename delete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants