Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test filtering in TestNG leads to no tests executing when configuration cache enabled #25859

Closed
abstratt opened this issue Jul 21, 2023 · 0 comments · Fixed by #25939
Closed

Test filtering in TestNG leads to no tests executing when configuration cache enabled #25859

abstratt opened this issue Jul 21, 2023 · 0 comments · Fixed by #25939
Assignees
@abstratt
Labels
@configuration-cache in:testing-testng
Milestone
8.4 RC1

Comments

@abstratt
Copy link
Member

abstratt commented Jul 21, 2023 •
edited

When #24613 was addressed via #25257 which was later rolled back and finally reinstated via #25740, we ended up having to disable tests that exercised test filtering features (in TestNG).

We must understand whether that is a problem with the tests or the feature under test in the context of configuration cache.

We later discovered test filtering was not working with configuration cache at all. Result was:

No tests found for given includes: ...
@abstratt abstratt added this to the 8.4 RC1 milestone Jul 21, 2023
@abstratt abstratt self-assigned this Jul 21, 2023
@abstratt abstratt mentioned this issue Jul 21, 2023
Closed
@abstratt abstratt changed the title Test NG filtering tests not working with configuration cache Test filtering in TestNG leads to no tests executing when configuration cache enabled Jul 27, 2023
@abstratt abstratt mentioned this issue Jul 27, 2023
Merged
abstratt added a commit that referenced this issue Jul 27, 2023
@abstratt
Make TestNG filtering compatible with CC
e745662 
TestNG supports filtering via <suite>...</suite>  [XML markup](https://testng.org/doc/documentation-main.html#testng-xml). To make this CC-compatible, we are now generating and caching the markup at serialization time, so it remains available during execution (as the objects required to build it are not persistable).

Fixes: #25859
bot-gradle added a commit that referenced this issue Jul 28, 2023
@bot-gradle @abstratt
Merge pull request #25939 Make TestNG filtering compatible with CC
71ce276 
TestNG supports filtering via \<suite\>...\</suite\>  [XML markup](https://testng.org/doc/documentation-main.html#testng-xml). To make this CC-compatible, we are now generating and caching the markup at serialization time, so it remains available during execution (as the objects required to build it - the markup writer and builder - are not persistable).

Fixes: #25859

Co-authored-by: Rafael Chaves <rchaves@gradle.com>
@github-actions github-actions bot mentioned this issue Oct 9, 2023
Closed
This was referenced Oct 17, 2023
Merged
Closed
Merged
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Merged
@sebhoss sebhoss mentioned this issue Nov 3, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 13, 2023
Closed
@github-actions github-actions bot mentioned this issue Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abstratt abstratt

Labels
@configuration-cache in:testing-testng
Projects
None yet
Milestone
8.4 RC1
Development

Successfully merging a pull request may close this issue.

Make TestNG filtering compatible with CC gradle/gradle
1 participant
@abstratt