Process property upgrades in each subproject separately #25990
Milestone
Comments
This was referenced Aug 4, 2023
|
I found one issue with annotation processor: currently we do full recompilation of Groovy tests, see: So we need to fix that. |
bot-gradle
added a commit
that referenced
this issue
Aug 22, 2023
…erceptor from plugins classloader via SPI And add Property upgrades instrumentation to plugins classpath. That way we don't have classloading issues in adapter logic, where we reference plugin types. Main changes: 1. With annotation processor we now generate also `META-INF/services/org.gradle.internal.classpath.intercept.CallInterceptor` and `META-INF/services/org.gradle.internal.instrumentation.api.jvmbytecode.JvmBytecodeCallInterceptor$Factory`. 2. In `DefaultClassLoaderRegistry` we load interceptors from plugins class loader as: `CallInterceptorRegistry.loadCallInterceptors(pluginsClassLoader);` 3. `instrumentation-declarations` are now a `pluginsRuntimeOnly` dependency of `:distribution-core` and not anymore a `runtimeOnly` dependency of `:launcher` Fixes #25893 Fixes #25894 This change will also make it simpler to implement #25990. ### Reviewing cheatsheet Before merging the PR, comments starting with - ❌ ❓**must** be fixed - 🤔 💅 **should** be fixed - 💭 **may** be fixed - 🎉 celebrate happy things Co-authored-by: Anže Sodja <asodja@gradle.com>
|
It seems issue #26085 is specific just for For such projects we can probably keep For reference, it seems we disabled incremental annotation processing for Groovy/Java joint compilation in #9871, because there were too many corner cases and supporting it was expensive. |
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have an annotation processor execute on each subproject individually to process
@UpgradedPropertydefinitions. This is to avoid the need for introducing dependencies from theinstrumentation-declarationssubproject.cc: @gradle/bt-execution
The text was updated successfully, but these errors were encountered: