Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestLauncher cannot launch tests from included builds when CC is enabled #26206

Closed
donat opened this issue Aug 29, 2023 · 1 comment · Fixed by #26243
Closed

TestLauncher cannot launch tests from included builds when CC is enabled #26206

donat opened this issue Aug 29, 2023 · 1 comment · Fixed by #26243
Assignees
@bamboo @donat
Labels
a:bug in:configuration-cache Configuration Caching in:tooling-api
Milestone
8.4 RC1

Comments

@donat
Copy link
Member

donat commented Aug 29, 2023 •
edited

Steps to reproduce:

  • Enable testlauncher support in IntelliJ
  • Import the gradle/gradle repository
  • Try to run GradleDistributionInstallTest
@donat donat added this to the 8.4 RC1 milestone Aug 29, 2023
@donat donat self-assigned this Aug 29, 2023
@mlopatkin mlopatkin added the in:configuration-cache Configuration Caching label Aug 30, 2023
@bamboo bamboo self-assigned this Aug 30, 2023
@ov7a ov7a added the a:bug label Sep 1, 2023
@bamboo bamboo mentioned this issue Sep 5, 2023
Merged
@donat donat linked a pull request Sep 6, 2023 that will close this issue
Let TestLauncher correctly find and configure tasks from included builds #26243
Merged
bot-gradle added a commit that referenced this issue Sep 6, 2023
@bot-gradle @bamboo
Merge pull request #26243 Let TestLauncher correctly find and confi…
02047ef 
…gure tasks from included builds

Treat requested task path as `<build path>:<project path>:<task name>` and find included build matching the longest task path prefix.

Fixes #26206

### Reviewing cheatsheet

Before merging the PR, comments starting with
- ❌ ❓**must** be fixed
- 🤔 💅 **should** be fixed
- 💭 **may** be fixed
- 🎉 celebrate happy things

Co-authored-by: Rodrigo B. de Oliveira <rodrigo@gradle.com>
@bamboo
Copy link
Member

bamboo commented Sep 6, 2023

Fixed via #26243

@github-actions github-actions bot mentioned this issue Oct 9, 2023
Closed
This was referenced Oct 17, 2023
Merged
Closed
Merged
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Merged
@sebhoss sebhoss mentioned this issue Nov 3, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 13, 2023
Closed
@github-actions github-actions bot mentioned this issue Nov 20, 2023
Closed
intellij-monorepo-bot pushed a commit to JetBrains/intellij-community that referenced this issue Dec 11, 2023
@HackerMadCat @intellij-monorepo-bot
IDEA-325181 [Gradle|Test] fix: don't use TestLauncher for a project w…
46ca96a 
…ith included builds

This bug in the Gradle was fixed in version 8.4
gradle/gradle#26206

GitOrigin-RevId: d2452b2b1873638b717afb061d9c0b501da6dc19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bamboo bamboo

@donat donat

Labels
a:bug in:configuration-cache Configuration Caching in:tooling-api
Projects
None yet
Milestone
8.4 RC1
Development

Successfully merging a pull request may close this issue.

Let TestLauncher correctly find and configure tasks from included builds gradle/gradle
4 participants
@bamboo @donat @ov7a @mlopatkin