Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker API documentation incorrectly says process isolation creates daemons that persist across builds #28479

Closed
3flex opened this issue Mar 16, 2024 · 4 comments
Labels
Milestone

Comments

@3flex
Copy link
Contributor

3flex commented Mar 16, 2024

Issue type

Wrong or misleading information

Problem description

https://docs.gradle.org/8.6/userguide/worker_api.html#creating_a_worker_daemon says

These worker daemon processes will persist across builds and can be reused during subsequent builds.

This is not accurate since #21632 changed workers to run session scoped instead of daemon scoped.

It also talks about performance improvements when using worker daemons:

Note that the execution time may be somewhat high. This is because Gradle has to start a new process for each worker daemon, which is expensive. However, if you run your task again, you’ll see that it runs much faster. This is because the worker daemon(s) started during the initial build have persisted and are available for use immediately during subsequent builds.

The last two sentences should be removed - there doesn't seem to be any performance benefit to using process isolation now, an in fact it will be quite slow because Gradle has to start a new process for each worker daemon for every build.

Context (optional)

No response

Page with the problem

https://docs.gradle.org/8.6/userguide/worker_api.html#creating_a_worker_daemon

@ov7a
Copy link
Member

ov7a commented Mar 18, 2024

This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

@ov7a ov7a removed the to-triage label Apr 4, 2024
@asodja asodja added good first issue Good for newcomers and removed 👋 team-triage Issues that need to be triaged by a specific team labels Apr 4, 2024
@asodja
Copy link
Member

asodja commented Apr 4, 2024

Thanks, that is a good point. We should change wording here.

This issue is actionable and it's a good issue for someone that wants to contribute.

@tianyeeT tianyeeT mentioned this issue Apr 28, 2024
9 tasks
@andrewkolda
Copy link

should this issue be closed

@ov7a
Copy link
Member

ov7a commented May 21, 2024

@andrewkolda indeed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants