-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker API documentation incorrectly says process isolation creates daemons that persist across builds #28479
Labels
Milestone
Comments
ov7a
added
in:daemon
in:workers
👋 team-triage
Issues that need to be triaged by a specific team
and removed
to-triage
labels
Mar 18, 2024
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary. |
asodja
added
good first issue
Good for newcomers
and removed
👋 team-triage
Issues that need to be triaged by a specific team
labels
Apr 4, 2024
Thanks, that is a good point. We should change wording here. This issue is actionable and it's a good issue for someone that wants to contribute. |
should this issue be closed |
@andrewkolda indeed. Thanks! |
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue type
Wrong or misleading information
Problem description
https://docs.gradle.org/8.6/userguide/worker_api.html#creating_a_worker_daemon says
This is not accurate since #21632 changed workers to run session scoped instead of daemon scoped.
It also talks about performance improvements when using worker daemons:
The last two sentences should be removed - there doesn't seem to be any performance benefit to using process isolation now, an in fact it will be quite slow because Gradle has to start a new process for each worker daemon for every build.
Context (optional)
No response
Page with the problem
https://docs.gradle.org/8.6/userguide/worker_api.html#creating_a_worker_daemon
The text was updated successfully, but these errors were encountered: