Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Jetty plugin #735

Closed
bmuschko opened this issue Oct 19, 2016 · 7 comments
Closed

Remove deprecated Jetty plugin #735

bmuschko opened this issue Oct 19, 2016 · 7 comments
Assignees
Milestone

Comments

@bmuschko
Copy link
Contributor

bmuschko commented Oct 19, 2016

The Jetty plugin has been deprecated with Gradle 3.0. The plugin including all its tests needs to be removed from the Gradle code base. Any testing coding code that relies on the Jetty plugin needs to be changed to use a different solution.

Expected Behavior

Delete the plugin code under jetty subproject and anything in the Gradle core infrastructure that uses it.

Current Behavior

Users will have to use the external Gretty plugin.

Context

The Jetty plugin in its current form does not provide a good user experience. It uses a very old version which is not configurable. Users expect more functionality of the plugin.

Your Environment

All environments.

@bmuschko bmuschko added this to the 4.0 milestone Oct 19, 2016
@bmuschko bmuschko added the jetty label Oct 19, 2016
@big-guy
Copy link
Member

big-guy commented Oct 20, 2016

I think we have things that use jetty, but not the jetty plugin. Do you think we would need to update things that use jetty (e.g., all of our HTTP/repo mocking infrastructure)?

@bmuschko
Copy link
Contributor Author

We can continue to use Jetty for testing infrastructure. That's totally fine. This work really is only about the fact that were are going to remove the Jetty plugin and therefore need to change everything that depends on it.

@eriwen eriwen removed this from the 4.0 milestone Oct 20, 2016
@bmuschko
Copy link
Contributor Author

@eriwen Why did you remove the milestone for this issue? The deprecation message and our documentation says that the plugin will be removed with 4.0.

@eriwen
Copy link
Contributor

eriwen commented Nov 28, 2016

@bmuschko Mistake on my part. We aren't doing any new deprecations in 4.0, but since this is already deprecated I'll put it back on the 4.0 milestone

@eriwen eriwen added this to the 4.0 milestone Nov 28, 2016
@bmuschko bmuschko modified the milestones: 4.0 RC1, 4.0 Dec 29, 2016
@eriwen eriwen modified the milestones: 3.5 RC1, 4.0 RC1 Feb 17, 2017
@pioterj
Copy link
Member

pioterj commented Mar 17, 2017

@pioterj
Copy link
Member

pioterj commented Mar 24, 2017

@eriwen eriwen self-assigned this Mar 30, 2017
eriwen added a commit that referenced this issue Mar 31, 2017
@eriwen
Copy link
Contributor

eriwen commented Apr 3, 2017

Closing as complete

@eriwen eriwen closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants