Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify file tree implementations #9056

Closed
wolfs opened this issue Feb 4, 2019 · 3 comments
Closed

Simplify file tree implementations #9056

wolfs opened this issue Feb 4, 2019 · 3 comments
Labels

Comments

@wolfs
Copy link
Member

wolfs commented Feb 4, 2019

We should have a look what file tree implementations we have in our code base and consolidate them. See #8403 for something similar for file collections.

@adammurdoch
Copy link
Member

There's still loads of stuff we can simplify for file collections too.

I'd like to make sure that all instantiation is done by a factory of some kind. There's really only a couple of patterns that we need to support and pushing the implementations behind a factory interface allows us to keep the number of different implementations low and make each on efficient. This structure also makes it easier to change the implementations and the services they need (for example, let's say we start using the file system mirror in the file collection implementations or we want to start firing build operations when they are queried, etc).

I'd also like to simplify how the contents of the collections are visited, when we build the graph nodes or unpack the collection to calculate the roots or when we register the watch points or query the contents. Each of these use cases has their own pattern and implementations for doing so. There's also complexity that happens because each caller needs to provide a way to resolve paths to files, whereas I think it would be simpler for each file collection to either be composed of other collections (possible lazily calculated) or can resolve its own content. Same for task dependencies too.

@lptr lptr transferred this issue from another repository Apr 15, 2019
@stale
Copy link

stale bot commented Aug 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. If you're interested in how we try to keep the backlog in a healthy state, please read our blog post on how we refine our backlog. If you feel this is something you could contribute, please have a look at our Contributor Guide. Thank you for your contribution.

@stale stale bot added the stale label Aug 27, 2020
@stale
Copy link

stale bot commented Sep 17, 2020

This issue has been automatically closed due to inactivity. If you can reproduce this on a recent version of Gradle or if you have a good use case for this feature, please feel free to reopen the issue with steps to reproduce, a quick explanation of your use case or a high-quality pull request.

@stale stale bot closed this as completed Sep 17, 2020
@wolfs wolfs closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants