Some FileCollection cleanup #8403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bjectFactory.fileCollection()`. Also replace usages of internal `FileOperations.configurableFiles()` method with the public API.
… bunch of places and into `FileCollectionFactory`.
…nstances to instead delegate to `FileCollectionFactory`.
…late the service(s) needed to create instances of this type and decouple clients from this detail. This could/should move to `ObjectFactory` or some other public factory type.
…h `FileCollectionFactory`.
…d by the client to decide whether to run the build in process or in the daemon, rather than using some hard-coded wiring. When the daemon is used, reuse the service instances too (not just the logic).
… delegate to `FileCollectionFactory`. Also merge some `FileCollection` implementations that do the same thing.
…ghtly earlier and avoid carrying around a `FileResolver`.
…nstances, rather than using internal `FileOperations`.
…ctLayout.configurableFiles()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR consolidates some of the various ways that
FileCollectioninstances are created into a factory so that this is easier to change in the future, merges someFileCollectionimplementations, and changes plugins to use public APIs instead of internal APIs to create FileCollection instances where an appropriate public API exists.This PR also deprecates
ProjectLayout.configurableFiles(), replaced byObjectFactory.fileCollection().Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew <changed-subproject>:checkGradle Core Team Checklist