Add validation at publication time #10769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
suggested changes
Sep 18, 2019
...src/main/java/org/gradle/api/publish/maven/internal/publication/DefaultMavenPublication.java
Show resolved
Hide resolved
...ojects/publish/src/main/java/org/gradle/api/publish/internal/GradleModuleMetadataWriter.java
Outdated
Show resolved
Hide resolved
...cts/maven/src/integTest/groovy/org/gradle/api/publish/maven/MavenPublishJavaIntegTest.groovy
Show resolved
Hide resolved
...rc/integTest/groovy/org/gradle/api/publish/maven/MavenPublishCustomComponentIntegTest.groovy
Show resolved
Hide resolved
...ojects/publish/src/main/java/org/gradle/api/publish/internal/GradleModuleMetadataWriter.java
Outdated
Show resolved
Hide resolved
This commit introduces validation when generating Gradle Module Metadata: - check that there's at least one variant published - each variant must have at least one attribute - there shouldn't be duplicate variant names - each variant must have a different (attributes,capabilities) combination Closes #10736
melix
force-pushed
the
cc/dm/issue-10736
branch
from
910ab2a
to
7f44fa7
Compare
jjohannes
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This commit introduces validation when generating Gradle
Module Metadata:
combination
Closes #10736