Reinstate Kotlin DSL IDE resolver short circuit behind an IDE flag #10946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamboo
reviewed
Oct 3, 2019
...-dsl/src/main/kotlin/org/gradle/kotlin/dsl/resolver/KotlinBuildScriptDependenciesResolver.kt
Outdated
Show resolved
Hide resolved
bamboo
approved these changes
Oct 3, 2019
subprojects/kotlin-dsl/src/main/kotlin/org/gradle/kotlin/dsl/resolver/ResolverEnvironment.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Merlin <paul@gradle.com>
Next IJ release will make use of that flag. It is unset by default, disabling the reintroduced short-circuit, in order not to break users of existing IJ versions. Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
eskatos
force-pushed
the
eskatos/kotlin-dsl/resolver-short-circuit
branch
from
d3185ae
to
3c51af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This short circuit combined with some upcoming changes in IJ will prevent
.gradle.ktsscript editors to constantly do TAPI requests as you type, and only do them when necessary.Next IJ release will make use of that flag.
It is unset by default, disabling the reintroduced short-circuit, in order not to break users of existing IJ versions.
See gradle/kotlin-dsl-samples#972