Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase build timeout if Gradle JARs need to be generated #1105

Merged
merged 2 commits into from Jan 5, 2017

Conversation

bmuschko
Copy link
Contributor

@bmuschko bmuschko commented Jan 5, 2017

Generating the Gradle JARs (e.g. Gradle API JAR) can add to the overall build time. Trigger generation of Gradle JARs before executing any test case (example of failing CI build).

@bmuschko bmuschko added a:chore Minor issue without significant impact from:member in:core DO NOT USE labels Jan 5, 2017
@bmuschko bmuschko self-assigned this Jan 5, 2017
@big-guy
Copy link
Member

big-guy commented Jan 5, 2017

Instead of bumping the timeout, why not just do this:

    def setup() {
        file("buildSrc/src/main/groovy/Thing.groovy") << """
            class Thing {
              public static final String VALUE = "original"
            }
        """
        succeeds("help")
    }

I think that will guarantee that the gradle-api jar is created once without entering continuous build.

@bmuschko
Copy link
Contributor Author

bmuschko commented Jan 5, 2017

@big-guy Good idea. Changed!

@big-guy big-guy merged commit ad5ab23 into master Jan 5, 2017
@big-guy big-guy deleted the bm-issue-669 branch January 5, 2017 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact in:core DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants