Register implicit capabilities for conflict detection in more cases #11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general conflict detection for implicit capabilities is skipped for performance optimization. However, if the corresponding capability is explicitly declared by another component that was visited *before*, we need to do the conflict detection between the component with the implicit capability and the one visited earlier.
melix
approved these changes
Nov 13, 2019
jjohannes
added a commit
that referenced
this pull request
Nov 13, 2019
…11334) In general conflict detection for implicit capabilities is skipped for performance optimization. However, if the corresponding capability is explicitly declared by another component that was visited *before*, we need to do the conflict detection between the component with the implicit capability and the one visited earlier. See also: #11300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general conflict detection for implicit capabilities is skipped
for performance optimization. However, if the corresponding capability
is explicitly declared by another component that was visited before,
we need to do the conflict detection between the component with
the implicit capability and the one visited earlier.