Deprecate alternative JVM plugins #11598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
added
in:dependency-management
jjohannes
commented
Dec 5, 2019
| @@ -31,7 +30,6 @@ | |||
| /** | |||
| * Options for Scala platform compilation. | |||
| */ | |||
| @Incubating | |||
There was a problem hiding this comment.
This type is also used by the "normal" scala plugin and is thus not deprecated. It should not be incubating.
adammurdoch
reviewed
Dec 5, 2019
...rojects/language-java/src/main/java/org/gradle/language/java/plugins/JavaLanguagePlugin.java
Outdated
Show resolved
Hide resolved
...testFixtures/groovy/org/gradle/api/tasks/compile/AbstractCachedCompileIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
|
I think we should document this in some form. We will just need to be careful about the wording. |
jjohannes
force-pushed
the
jjohannes/deprecate-alternative-jvm-plugins
branch
3 times, most recently
from
1aa9473
to
435cc83
Compare
|
Thanks for the feedback @adammurdoch . I added a section to the upgrading guide: 9ebe8e4 Before I adjust all tests, I would like to decide on a deprecation warning. Proposal (would add the same message for all deprecations): Renders to: |
jjohannes
force-pushed
the
jjohannes/deprecate-alternative-jvm-plugins
branch
4 times, most recently
from
5943ad5
to
fad870e
Compare
jjohannes
force-pushed
the
jjohannes/deprecate-alternative-jvm-plugins
branch
from
fad870e
to
17485f5
Compare
jjohannes
added a commit
that referenced
this pull request
Feb 19, 2020
This was deprecated as part of #11598. We missed that it can also be used in artifact resolution queries which are not (yet) deprecated. For example: dependencies { createArtifactResolutionQuery().withArtifacts(JvmLibrary, ...) }
jjohannes
added a commit
that referenced
this pull request
Feb 22, 2020
This was deprecated as part of #11598. We missed that it can also be used in artifact resolution queries which are not (yet) deprecated. For example: dependencies { createArtifactResolutionQuery().withArtifacts(JvmLibrary, ...) }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9837
Notes:
@Deprecatedto all API types that are exclusively used by the deprecated plugins. In particular, I checked everything that was still incubating in the corresponding projects, because a type that has been around since Gradle 2.x/3.x should either be deprecated or be de-incubated. There is one type,JavadocArtifact, which I left incubating but did not deprecate (yet) because it is also used in the artifact query API (which we will probably also deprecate soonish).