remove duplicate then statement; collapse duplicate if statements #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimreaper
commented
Jan 20, 2017
| } else { | ||
| action.processFile(f); | ||
| } | ||
| action.processFile(f); |
There was a problem hiding this comment.
a cursory inspection seems to indicate this is the correct fix but there is a good chance I missed the logic here and really the the first if statement should be changed.
There was a problem hiding this comment.
This logic is correct assuming that f.isDirectory() has no side effects. I checked all implementors of FileCopyDetails.isDirectory() and that seems to be correct.
|
@grimreaper Thanks for the quick cleanup PR. I'm afraid I don't see a CLA from you yet. Would you please sign one so we can move forward? |
|
signed |
|
@grimreaper thanks! — merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.