-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a system property to configure the daemon log level #12223
Conversation
e4cd3b9
to
78e199b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can't we simulate org.gradle.daemon.disable-output
by setting the log level to OFF
now?
No, |
In that case I think we should re-initialize the log level before we check that switch. |
78e199b
to
87b3022
Compare
If we re-initialize logging before checking |
Even when disable output is switched on.
Switching to info doesn't seem feasible, since then we lose the timestamps in the daemon logs, which seem to be important for users. It seems hard to produce timestamps with info logging in the daemon logs, since the logs are emitted by Closing this PR. |
Related to #2688
Currently, the daemon always logs with
DEBUG
log level in the daemon log. This was fine up to now (mostly), since not much happened between builds.When file watching is enabled, a lot happens between builds - file changes are collected. In order to prevent the daemon log to overflow, it should be possible to set the log level differently - e.g. to
INFO
.This PR introduces a system property
org.gradle.daemon.loglevel
which the daemon tries to pick up from the current build context and then changes the logging level after the build accordingly.