Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add always runs after task scheduling #134

Merged
merged 14 commits into from Mar 12, 2013
Merged

Add always runs after task scheduling #134

merged 14 commits into from Mar 12, 2013

Conversation

erdi
Copy link
Contributor

@erdi erdi commented Feb 28, 2013

@erdi
Refactored DefaultTaskExecutionPlan to use TaskDependencyGraph to det…
c83053b 
…ermine execution plan
@erdi
Added 'must run after' task ordering
978cc57
@erdi
Order buildDashboard tasks to always run after reporting tasks
1941032
@erdi
Do not track nodes without incoming edges in TaskDependencyGraph and …
2297b62 
…use added tasks as entry points to execution plan in DefaultTaskExecutionPlan
@erdi
Simplify adding graph nodes and edges
4b9922d
@erdi
Differentiate between soft and hard edges in TaskDependencyGraph
cb721f3
@erdi
Add mustRunAfter dependencies before regular dependencies to executio…
3e8d18a 
…n plan, continue execution of task with must run after dependency if the dependee task fails
@erdi
Reduce number of task lookups in graph
7da89fb
@erdi
Merged TaskInfo and TaskDependencyGraphNode
94470c3
@erdi
Determine executionPlan only after all tasks are added
5d03752
@erdi
Lazy evaluation of must run after dependencies
8ed7536
@erdi
Add user nagging for Task.setMustRunAfter(Iterable)
e27a18c
@erdi
Use NON_REQUIRED state in TaskInfo instead of required field and remo…
7c9a33f 
…ve executionDependencies field
@erdi
Add docs around mustRunAfter
42c4f88
@ghost ghost assigned bigdaz Mar 12, 2013
@bigdaz bigdaz merged commit 42c4f88 into gradle:master Mar 12, 2013
@bigdaz
Copy link
Member

bigdaz commented Mar 12, 2013

Thanks Marcin. I've merge the pull request - it looks great.
The only problem I encountered was that the lazy population of the task graph broke support for the --dry-run command line option. (It was also a breaking change in behaviour of TaskGraphExecuter). I changed the code to populate the graph on demand, only failing if there were not yet any tasks added.

I also added a couple of integration tests: one thing that might be worth adding is support for:
task foo(mustRunAfter: 'b')
The fact that this syntax is used in a unit test led me to believe that this would work in a build as well!

Thanks again.
Daz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bigdaz bigdaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erdi @bigdaz