Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate code quality plugin configurations for consumption #16995

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Deprecate code quality plugin configurations for consumption #16995

merged 4 commits into from
Apr 30, 2021

Conversation

rieske
Copy link
Contributor

@rieske rieske commented Apr 27, 2021

@rieske rieske added the @core Issue owned by GBT Core label Apr 27, 2021
@rieske rieske added this to the 7.1 RC1 milestone Apr 27, 2021
@rieske rieske self-assigned this Apr 27, 2021
@rieske rieske force-pushed the vv/deprecations/code-quality-config-consumption branch from 4c2f2d9 to fd38510 Compare April 27, 2021 18:04
@rieske rieske marked this pull request as ready for review April 29, 2021 10:23
@rieske rieske requested a review from ljacomet April 29, 2021 10:23
ljacomet
ljacomet approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@ljacomet ljacomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the upgrade notes are great!

@rieske
Copy link
Contributor Author

rieske commented Apr 30, 2021

@bot-gradle test and merge, please.

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

@bot-gradle bot-gradle mentioned this pull request Apr 30, 2021
Merged
@bot-gradle bot-gradle merged commit f6abadb into master Apr 30, 2021
@rieske rieske deleted the vv/deprecations/code-quality-config-consumption branch April 30, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljacomet ljacomet ljacomet approved these changes

Assignees

@rieske rieske

Labels
@core Issue owned by GBT Core
Projects
None yet
Milestone
7.1 RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rieske @bot-gradle @ljacomet