Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deprecation checks for smoke tests #17044

Merged
merged 26 commits into from
May 7, 2021
Merged

Improve deprecation checks for smoke tests #17044

merged 26 commits into from
May 7, 2021

Commits on May 2, 2021

  1. Remove expectations about AGP versions < 4.0 

    We are not running tests with AGP 3.6 and earlier anymore.
    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    9ee255c View commit details
    Browse the repository at this point in the history

  2. Move deprecation waring expectations to smoke-test specific GradleRunner 

    A major benefit of this is that we always check for warnings automatically.
    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    8193ff6 View commit details
    Browse the repository at this point in the history

  3. Expose SmokeTestGradleRunner in more places

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    e732b1f View commit details
    Browse the repository at this point in the history

  4. Add expectations for a number of recently introduced deprecations

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    4ad6833 View commit details
    Browse the repository at this point in the history

  5. More expectations for WorkerExecutor.submit() deprecation

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    d6df8a0 View commit details
    Browse the repository at this point in the history

  6. Add missing deprecation warning expecatation

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    dac7247 View commit details
    Browse the repository at this point in the history

  7. Replace deprecated Report.enabled with Report.required

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    add9c78 View commit details
    Browse the repository at this point in the history

  8. Ignore deprecation warnings in the Gradle build

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    f1fe8b3 View commit details
    Browse the repository at this point in the history

  9. Add more expected deprecations

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    7616daf View commit details
    Browse the repository at this point in the history

  10. Add missing deprecation warning

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    9c47c54 View commit details
    Browse the repository at this point in the history

  11. Add followup todos 

    These should be replaced with links to followup issues with the respective plugins.
    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    95ef332 View commit details
    Browse the repository at this point in the history

  12. Fix unnecessary cast

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    23ad309 View commit details
    Browse the repository at this point in the history

  13. Add more expected deprecations for AGP tests

    @lptr
    lptr committed May 2, 2021
    Configuration menu
    Copy the full SHA
    df727e3 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Do something special when configuration caching is enabled

    @lptr
    lptr committed May 3, 2021
    Configuration menu
    Copy the full SHA
    c7a2838 View commit details
    Browse the repository at this point in the history

  2. Introduce expectLegacyDeprecationWarning()

    @lptr
    lptr committed May 3, 2021
    Configuration menu
    Copy the full SHA
    0799506 View commit details
    Browse the repository at this point in the history

  3. Link to Freefair AspectJ issue

    @lptr
    lptr committed May 3, 2021
    Configuration menu
    Copy the full SHA
    7bfc329 View commit details
    Browse the repository at this point in the history

  4. Link to Gretty issue

    @lptr
    lptr committed May 3, 2021
    Configuration menu
    Copy the full SHA
    56a6d9e View commit details
    Browse the repository at this point in the history

  5. Link to Nebula plugin issue

    @lptr
    lptr committed May 3, 2021
    Configuration menu
    Copy the full SHA
    844d2d3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Refer to some followup issues

    @lptr
    lptr committed May 4, 2021
    Configuration menu
    Copy the full SHA
    4b7e1f0 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Add expected deprecations in Play plugin smoke test

    @rieske
    rieske committed May 5, 2021
    Configuration menu
    Copy the full SHA
    0c33856 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @rieske
    rieske committed May 5, 2021
    Configuration menu
    Copy the full SHA
    fd3b924 View commit details
    Browse the repository at this point in the history

  3. Fix Android smoke test deprecation expectations 

    This test runs Gradle multiple times - we have to clean up
the expectations after asserting them to start clean for
the next iteration that may or may not add its own deprecation
expectations.
    @rieske
    rieske committed May 5, 2021
    Configuration menu
    Copy the full SHA
    58bc224 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Merge branch 'master' into lptr/smoke-tests/link-deprecation-followup 

    # Conflicts:
#	subprojects/smoke-test/src/smokeTest/groovy/org/gradle/smoketests/AndroidSantaTrackerSmokeTest.groovy
#	subprojects/smoke-test/src/smokeTest/groovy/org/gradle/smoketests/KotlinPluginSmokeTest.groovy
    @rieske
    rieske committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d01b93f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Update smoke test deprecation expectations mitigating Kotlin 1.5.0-RC… 

    … impact
    @rieske
    rieske committed May 7, 2021
    Configuration menu
    Copy the full SHA
    ae2f62f View commit details
    Browse the repository at this point in the history

  2. Update smoke test deprecation expectation for config cache execution

    @rieske
    rieske committed May 7, 2021
    Configuration menu
    Copy the full SHA
    fac2fae View commit details
    Browse the repository at this point in the history

  3. Simplify conditional deprecation warnings in smoke tests 

    Making it more explicit that certain deprecations are only valid
with older version of AGP plugin.
    @rieske
    rieske committed May 7, 2021
    Configuration menu
    Copy the full SHA
    7e50f6c View commit details
    Browse the repository at this point in the history