Remove deprecated CompileOptions.annotationProcessorGeneratedSourcesDirectory property #17105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory property
# Conflicts: # subprojects/docs/src/docs/dsl/org.gradle.api.tasks.compile.CompileOptions.xml
Closed
8 tasks
AGP and KGP both used deprecated compile options, and needed to be upgraded. This caused the expected module and pom files used by
this test to change significantly in several ways:
1) Kotlin version numbers needed bumping.
2) Less variants were present (for example - "metadataApiElements-published" gone from "kotlin-multiplatform-android-library-android-demo-1.0.module")
3) Names of existing variants changed (for example - "metadataApiElements-published" became "metadataApiElements" in "kotlin-multiplatform-library-1.0.module")
4) Variant had less attributes present (for example - "com.android.build.api.attributes.VarianttAttr" is gone)
5) Some new attributes present (for example - "artifactType = org.jetbrains.kotlin.klib")
In addition, other properties in the Android extension were removed ("versionCode", "versionName").
But the biggest change necessary was in the comparison logic within this smoke test itself. The order of the dependencies present in GMM and POM files
doesn't seem to be fixed. This causes the existing comparisons to fail unless corrected. This test now sorts the dependencies and then compares the results
of sorting. Without this code, this test becomes flaky as the order of these nodes in the expected files needs to be changed to match...and then the next time
you run the test, it needs to be changed BACK.
…sDirectory deprecations - Using Gradle 8.0 in expected warning until #21549 merges to master, then will update to 9.0.
tresat
force-pushed
the
vv/8-removals/compile-options
branch
from
7c134a8
to
60235f4
Compare
|
@gradle/bt-core - After updating this branch with the current state of master, I believe all the previous issues are resolved and it is ready to merge. |
big-guy
approved these changes
Oct 10, 2022
|
OK, I've already triggered a build for you. |
|
Pre-tested commit build failed. |
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
|
Pre-tested commit build failed. |
|
Performance tests fail upon merge due to problems running sync with Android Studio on this generated performance test. The issue is the usage of This is blocked until that is changed in a newer version of Android Studio. |
|
@tresat we'll have to punt this to 9.0. We're not going to make it so Gradle 8.0 only works with the latest IntelliJ |
This was referenced Dec 9, 2022
bot-gradle
added a commit
that referenced
this pull request
Dec 12, 2022
…irectory nag to 9.0 We are punting removal of this method to 9.0 since intellij uses it. See: #17105 Co-authored-by: Justin Van Dort <jvandort@gradle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15681