Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define scala source set with extension #17163

Merged
merged 1 commit into from
May 18, 2021
Merged

Define scala source set with extension #17163

merged 1 commit into from
May 18, 2021

Conversation

donat
Copy link
Member

@donat donat commented May 11, 2021

This is a follow-up PR to #17149. Here, clean up the usages of conventions in the scala plugin. The conventions are unmodified as they will be deprecated in a separate step.

@big-guy big-guy added this to the 7.1 RC1 milestone May 11, 2021
@gradle gradle deleted a comment from donat May 12, 2021
@gradle gradle deleted a comment from donat May 12, 2021
@donat donat marked this pull request as ready for review May 12, 2021 11:39
@donat donat requested review from big-guy and rieske May 12, 2021 11:44
@big-guy big-guy added the @core Issue owned by GBT Core label May 12, 2021
Copy link
Member

@big-guy big-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see what I said in the Groovy PR

@donat donat requested a review from pioterj as a code owner May 17, 2021 16:18
@donat donat changed the base branch from master to donat/convention/antlr-dslobject May 18, 2021 08:36
@donat donat force-pushed the donat/convention/scala branch 2 times, most recently from 86aa036 to 02baad0 Compare May 18, 2021 08:55
@gradle gradle deleted a comment from donat May 18, 2021
@donat
Copy link
Member Author

donat commented May 18, 2021

@bot-gradle test rFM

@gradle gradle deleted a comment from donat May 18, 2021
@bot-gradle
Copy link
Collaborator

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

Base automatically changed from donat/convention/antlr-dslobject to master May 18, 2021 09:33
@donat
Copy link
Member Author

donat commented May 18, 2021

@bot-gradle test rFM

@gradle gradle deleted a comment from donat May 18, 2021
@bot-gradle
Copy link
Collaborator

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@donat donat merged commit 76dcbe9 into master May 18, 2021
@donat donat deleted the donat/convention/scala branch May 18, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@core Issue owned by GBT Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants