Pass more information to top exception on build cache load/store failure #19672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
reviewed
Jan 24, 2022
...-cache/src/main/java/org/gradle/caching/internal/controller/DefaultBuildCacheController.java
Outdated
Show resolved
Hide resolved
subprojects/execution/src/main/java/org/gradle/internal/execution/steps/BuildCacheStep.java
Outdated
Show resolved
Hide resolved
...ects/execution/src/test/groovy/org/gradle/internal/execution/steps/BuildCacheStepTest.groovy
Outdated
Show resolved
Hide resolved
...-integ-testing/src/main/groovy/org/gradle/integtests/fixtures/AbstractIntegrationSpec.groovy
Show resolved
Hide resolved
...s/core/src/integTest/groovy/org/gradle/api/tasks/CacheTaskArchiveErrorIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...s/core/src/integTest/groovy/org/gradle/api/tasks/CacheTaskArchiveErrorIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
subprojects/execution/src/main/java/org/gradle/internal/execution/steps/BuildCacheStep.java
Outdated
Show resolved
Hide resolved
asodja
force-pushed
the
asodja/build-cache-exceptions
branch
from
03572b3
to
bd977fa
Compare
asodja
force-pushed
the
asodja/build-cache-exceptions
branch
from
8b1e038
to
b21c17c
Compare
asodja
force-pushed
the
asodja/build-cache-exceptions
branch
from
b21c17c
to
f89c3e8
Compare
lptr
reviewed
Feb 21, 2022
...s/core/src/integTest/groovy/org/gradle/api/tasks/CacheTaskArchiveErrorIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
|
@bot-gradle test this |
|
OK, I've already triggered the following builds for you: |
lptr
reviewed
Feb 21, 2022
| @@ -217,7 +217,7 @@ class BuildCacheStepTest extends StepSpec<IncrementalChangesContext> implements | |||
|
|
|||
| then: | |||
| def ex = thrown Exception | |||
| ex.message == "Failed to store cache entry $cacheKeyHashCode for job ':test': store failure" | |||
| ex.message == "Failed to store cache entry 30a042b90a for job ':test': store failure" | |||
There was a problem hiding this comment.
Is this intentional? Why not use the variable instead?
There was a problem hiding this comment.
Yes, it is. This was not changed when fixing: #19672 (comment)
|
@bot-gradle test and merge |
|
Your PR is queued. See the queue page for details. |
|
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we pass more information to the top-level exception.
If previously exception was like:
Then top-level exception message looks like this now for load operation:
Also, we don't say anymore:
Build cache entry xxx from local build cache is invalidsince this might be confusing. It is changed to:Exception occurred while loading cache entry xxx from local build cacheI also changed the error for store operation to have similarly more information on the top-level as load has.
Fixes #17208