Conditionally enable Groovy 4 for testing

[lptr]

This is a cleaned up version of #18552.

Building with -DbundleGroovy4=true on the CLI will use Groovy 4.0.7 libs. An additional Gradleception job is already in place to invoke this code path.

If we choose to unconditionally upgrade to Groovy 4, we should revert this PR followed by setting the Groovy version value in ExternalModulesExtension.kt.

Alternatively, we could modify this PR to test forward with Groovy 5. This would likely also need temporary inclusion of apache snapshot repositories; see #20972.

Preparation PRs

• Prepare for Groovy 4 upgrade #18665
• Upgrade to Spock 2.1 #20037
• Fix #21503: Refactor references to deprecated AntBuilder package #21504
• Groovy 4 safe changes #21497
• Required fixes for future Groovy 4 compatibility #21986
• Parameterize Gradleception configuration to conditionally build with … #22097
• Cast to workaround GROOVY-10765 #22130
• Upgrade CodeNarc to 3.1.0 #22133
• Fix getter generation for String constant fields #22151
• Choose correct spock version based on bundled Groovy #22157
• Upgrade the spock version used in samples/snippets #22158
• Refactor tests to run with both Groovy 3 and Groovy 4 #22178
• More Groovy 4 safe changes #22208
• Future-facing Groovy 4 compatibility changes #22213

TODO

• allow configuration-cache instrumentation to handle INVOKEDYNAMIC
  • Rewrite dynamic Groovy call interception to make it more generic #20795
  • Instrument indy-based Groovy call sites #20799
  • [WIP] Proof of concept to instrument Groovy indy callsites #20616
• fix capabilities
• mention relevant breaking changes in release notes/upgrade guide
  • is*() getters are not supported for Boolean properties anymore; see Warn on Boolean properties beginning in 8.x #22218
  • INVOKEDYNAMIC is the only way forward
• upgrade Spock to Groovy 4-compatible version – Add Groovy 4 support spockframework/spock#1382
  • upgrade to Spock 2.2 GA
  • upgrade to Spock 2.2-M1
• upgrade CodeNarc – Upgrade CodeNarc to 3.0.1 #20655
  • Use XmlParserFactory CodeNarc/CodeNarc#678
    • this prevents running CodeNarc because it depends on the now-removed groovy.utils.XmlParser
    • it makes IsolatedAntBuilderMemoryLeakIntegrationTest.CodeNarc does not fail with PermGen space error fail
  • Support Groovy 4.x source files CodeNarc/CodeNarc#682
• upgrade to Groovy 4
  • upgrade to Groovy 4.0.7
  • GROOVY-10765 STC: Closure implementation of Java @FunctionalInterface loses type information
    • Can workaround using a cast in UnitOfWorkBuilder
    • Fix coming in 4.0.6
  • GROOVY-10731 Exceptions thrown from MarkupTemplateEngine when map accessors and GString interpolation are used
    • fixed in 4.0.5
  • GROOVY-10709 Performance regression in Gradle with Groovy 4
    • no clear cause; mitigation/investigation is ongoing
  • GROOVY-10708 Property access for wrapped vs. primitive boolean
    • Groovy team will not fix
    • @big-guy has suggested a workaround in Gradle to prevent breaking legacy plugins/tasks, to be implemented as Warn on Boolean properties beginning in 8.x #22218
  • GROOVY-10772 Possible memory leak, CacheableCallSite retains objects across invocations
    • Causes OOME-related flakiness in o.g.w.i.WorkerExecutorIntegrationTest#does not leak project state across multiple builds, and OOME mostly happens with Java 8
  • GROOVY-10707 Regression in property access for conflicting isXxx and getXxx accessors
    • Groovy team will not fix
    • Our tests are refactored to accommodate the breaking change
  • GROOVY-10591 Static method not found on Java interface
    • no fix planned yet
  • GROOVY-10543 Problem with groovy-all Gradle module metadata
    • fixed in 4.0.2
  • GROOVY-10514 Class method is not called anymore from inside closure
    • apparently works as designed, added workarounds
  • GROOVY-10555 MetaClass.getProperites() returns package private fields
    • no plan to fix yet, but added a workaround
  • GROOVY-10521 Compiler complains about abstract method not implemented when implementing trait
    • not fixed yet, but we added a workaround
  • GROOVY-10466 Compilation error on Spock expectation
    • To be fixed in GROOVY-9866, GROOVY-10466: resolve all class headers before class bodies apache/groovy#1698
    • Fixed in 4.0.2-SNAPSHOT
  • GROOVY-10467 Compilation fails with method detected as transient
    • doesn't seem to be a problem with 4.0.1
  • GROOVY-10299 Groovy compiler generates invalid Java stubs
    • already fixed in 4.0.0-beta-2
  • GROOVY-10290 Dynamic Groovy code in Gradle doesn't compile because of $getLookup() method is not static
    • fixed in 4.0.1
• fix build scripts being compiled with binary compatibility (=class format version) of the runtime Java version
  • this makes the following tests fail:
    • WorkerDaemonIntegrationTest
    • ConfigureRuntimeClasspathNormalizationIntegrationTest
    • CheckstylePluginToolchainsIntegrationTest
    • BuildEnvironmentIntegrationTest
• use non-deprecated Groovy AntBuilder for the super-class of our own AntBuilder
• upgrade Groovy version in AbstractSourcesAndJavadocJarsIntegrationTest
• use org.apache.groovy group ID for Groovy versions > 4 in GroovyParametersMetadataIntegrationTest (and probably in many other places)

[DPUkyle]

Note: this is currently blocked pending resolution of GROOVY-10772

[lptr]

Hm. When looking at performance regressions I remember that in some of our tests we've seen an increase in GC time. Could this be the reason, I wonder?

[big-guy]

@bot-gradle test this

[bot-gradle]

I've triggered the following builds for you:

• PullRequestFeedback build

[octylFractal]

@bot-gradle test and merge

[bot-gradle]

I've triggered a build for you.